Date: Sun, 26 Jul 2015 12:40:26 +0200 From: Koop Mast <kwm@rainbow-runner.nl> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, antoine@freebsd.org Subject: Re: svn commit: r392902 - in head/multimedia: . gstreamer1-plugins gstreamer1-plugins-hls Message-ID: <55B4B91A.2040900@rainbow-runner.nl> In-Reply-To: <20150726123658.08667f6f@kalimero.tijl.coosemans.org> References: <201507251959.t6PJxau6007387@repo.freebsd.org> <55B3FC33.4000903@rainbow-runner.nl> <20150726123658.08667f6f@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26-7-2015 12:36, Tijl Coosemans wrote:
> On Sat, 25 Jul 2015 23:14:27 +0200 Koop Mast <kwm@rainbow-runner.nl> wrote:
>> On 25-7-2015 21:59, Tijl Coosemans wrote:
>>> --- head/multimedia/gstreamer1-plugins/Makefile Sat Jul 25 17:11:37 2015 (r392901)
>>> +++ head/multimedia/gstreamer1-plugins/Makefile Sat Jul 25 19:59:35 2015 (r392902)
>>> @@ -147,20 +147,8 @@ post-patch:
>>> s|$$(top_builddir)/gst-libs/gst/video/libgstbasevideo-@GST_API_VERSION@.la|-lgstbasevideo-${VERSION}|; \
>>> s|$$(top_builddir)/gst-libs/gst/video/libgstvideo-@GST_API_VERSION@.la|-lgstvideo-${VERSION}|; \
>>> s|$$(top_builddir)/gst-libs/gst/base/libgstbadbase-@GST_API_VERSION@.la|-lgstbadbase-${VERSION}|; \
>>> + s|$$(top_builddir)/gst-libs/gst/uridownloader/libgsturidownloader-@GST_API_VERSION@.la|-lgsturidownloader-${VERSION}|; \
>>> s|$$(top_builddir)/gst-libs/gst/video/libgstbadvideo-@GST_API_VERSION@.la|-lgstbadvideo-${VERSION}|'
>>> -
>>> - @${FIND} ${WRKSRC}/ext ${WRKSRC}/sys -name Makefile.in | \
>>> - ${XARGS} -n 10 ${REINPLACE_CMD} -e \
>>> - '/la_DEPENDENCIES/,/am__DEPENDENCIES/s,$$(top_builddir)/gst-libs/.*.la,,' -e \
>>> - 's|$$(top_builddir)/gst-libs/gst/tag/libgsttag-$$(GST_API_VERSION).la|-lgsttag-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/audio/libgstaudio-$$(GST_API_VERSION).la|-lgstaudio-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/pbutils/libgstpbutils-$$(GST_API_VERSION).la|-lgstpbutils-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/riff/libgstriff-$$(GST_API_VERSION).la|-lgstriff-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/signalprocessor/libgstsignalprocessor-$$(GST_API_VERSION).la|-lgstsignalprocessor-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/video/libgstbasevideo-$$(GST_API_VERSION).la|-lgstbasevideo-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/video/libgstvideo-$$(GST_API_VERSION).la|-lgstvideo-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/base/libgstbadbase-$$(GST_API_VERSION).la|-lgstbadbase-${VERSION}|; \
>>> - s|$$(top_builddir)/gst-libs/gst/video/libgstbadvideo-$$(GST_API_VERSION).la|-lgstbadvideo-${VERSION}|'
>>> .endif
>> Just making sure, have you tested this change? Because the last time I
>> looked it was still needed. Note the difference between
>> $$(GST_API_VERSION) and @GST_API_VERSION@
> Oops, I've combined both into one RE now in r392917.
Thanks, and thanks for reducing the blob into something that is more
clean. Though now I need a almanac to figure out what the regex does but
I guess that is a small price to pay.
-Koop
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55B4B91A.2040900>