From owner-cvs-all@FreeBSD.ORG Tue Feb 6 16:57:30 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E6E0816A413; Tue, 6 Feb 2007 16:57:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id BE6CD13C4BA; Tue, 6 Feb 2007 16:57:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l16Gv90w070927; Tue, 6 Feb 2007 11:57:19 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Mike Pritchard Date: Tue, 6 Feb 2007 11:17:26 -0500 User-Agent: KMail/1.9.1 References: <200702060551.l165ptc4064006@repoman.freebsd.org> In-Reply-To: <200702060551.l165ptc4064006@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200702061117.27001.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 06 Feb 2007 11:57:20 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2527/Tue Feb 6 05:14:46 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2007 16:57:31 -0000 On Tuesday 06 February 2007 00:51, Mike Pritchard wrote: > mpp 2007-02-06 05:51:55 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_witness.c > Log: > The change to the vm_page_queue_freelist lock from a spin lock to a > sleep lock missed the witness code, and the system will panic > immediately on boot if WITNESS is enabled. > > Changed the witness definition to the new type. You had better take it out altogether. Now you've told witness that this lock comes after a spin lock, and that is only going to result in pain and suffering. -- John Baldwin