From owner-cvs-all@FreeBSD.ORG Fri Feb 3 22:13:41 2012 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id B38AB106566B; Fri, 3 Feb 2012 22:13:41 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-150-251.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id D4C60152462; Fri, 3 Feb 2012 22:13:40 +0000 (UTC) Message-ID: <4F2C5C14.8070605@FreeBSD.org> Date: Fri, 03 Feb 2012 14:13:40 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:10.0) Gecko/20120201 Thunderbird/10.0 MIME-Version: 1.0 To: Alexey Dokuchaev References: <201202030851.q138pWbE025501@repoman.freebsd.org> <20120203163537.GA6473@FreeBSD.org> In-Reply-To: <20120203163537.GA6473@FreeBSD.org> X-Enigmail-Version: 1.3.5 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Daniel Eischen , cvs-ports@freebsd.org, Eitan Adler , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/editors/nedit/files patch-util-misc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2012 22:13:41 -0000 On 02/03/2012 08:35, Alexey Dokuchaev wrote: > I concur. While it's very tempting to fix FreeBSD port (especially when > it's maintained by you (not you == Daniel, but in general sense)) we should > always first contact upstream maintainers/vendor and submit a fix and (at > best) ask for review. Right, with the qualification you gave below. I'd also add an exception for "Obviously correct change" since I like to think that we can give our maintainers credit for a clue or 2. :) > In case upstream maintainers are not very responsive, > but fix is critical or trivial enough, it's OK to fix such port directly, > but upstream bug tracker should be filled with detailed bug description and > attached patch. I'd also add that mentioning "I did/did not submit this upstream because..." and if appropriate, "... and I was told that ..." to the commit log would be a good thing. Not only for those of us who review these things as they go by, but also for posterity in case things don't go as planned. -- It's always a long day; 86400 doesn't fit into a short. Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/