Date: Fri, 20 Jul 2012 01:55:11 GMT From: Glen Barber <gjb@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/170014: [patch] net/fping: Update to OPTIONSNG, enforces usage of with or without IPv6 Message-ID: <201207200155.q6K1tBLT046413@red.freebsd.org> Resent-Message-ID: <201207200200.q6K20TYC053161@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 170014
>Category: ports
>Synopsis: [patch] net/fping: Update to OPTIONSNG, enforces usage of with or without IPv6
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Jul 20 02:00:29 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Glen Barber
>Release: 10.0-CURRENT #18 r237614
>Organization:
>Environment:
FreeBSD nucleus 10.0-CURRENT FreeBSD 10.0-CURRENT #18 r237614: Tue Jun 26 22:30:48 EDT 2012 root@nucleus:/usr/obj/usr/src/sys/NUCLEUS amd64
>Description:
The net/fping port can be build with IPv6 support, however this is not compatible with the default IPv4.
I propose the attached patch, which:
1.) Updates the port to use OPTIONSNG;
2.) As a result of 1, enforces the selection of no more than one NET (IPV4 or IPV6) option.
>How-To-Repeat:
>Fix:
Patch is attached, will await maintainer feedback.
Patch attached with submission follows:
Index: head/net/fping/Makefile
===================================================================
--- head/net/fping/Makefile (revision 301201)
+++ head/net/fping/Makefile (working copy)
@@ -23,7 +23,17 @@
CONFIGURE_ARGS= --bindir="${PREFIX}/sbin"
MAN8= fping.8
-.if defined(WITH_IPV6)
+OPTIONS_SINGLE= NET
+OPTIONS_SINGLE_NET=IPV4 IPV6
+
+OPTIONS_DEFAULT=IPV4
+
+IPV4_DESC= IPv4 support
+IPV6_DESC= IPv6 support
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MIPV6}
# IPv6 not enabled by default, as it does not work together with IPv4.
CFLAGS+= -DIPV6
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207200155.q6K1tBLT046413>