From owner-freebsd-bugs@FreeBSD.ORG  Mon Jan  7 15:10:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 6A087385
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon,  7 Jan 2013 15:10:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 38FE8F6A
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon,  7 Jan 2013 15:10:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r07FA1JH034031
 for <freebsd-bugs@freefall.freebsd.org>; Mon, 7 Jan 2013 15:10:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r07FA1i6034028;
 Mon, 7 Jan 2013 15:10:01 GMT (envelope-from gnats)
Resent-Date: Mon, 7 Jan 2013 15:10:01 GMT
Resent-Message-Id: <201301071510.r07FA1i6034028@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Tatsuki Makino <tatsuki_makino@hotmail.com>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 1CD25205
 for <freebsd-gnats-submit@FreeBSD.org>; Mon,  7 Jan 2013 15:04:21 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id 0EAC6F21
 for <freebsd-gnats-submit@FreeBSD.org>; Mon,  7 Jan 2013 15:04:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r07F4KHt061928
 for <freebsd-gnats-submit@FreeBSD.org>; Mon, 7 Jan 2013 15:04:20 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r07F4KMs061927;
 Mon, 7 Jan 2013 15:04:20 GMT (envelope-from nobody)
Message-Id: <201301071504.r07F4KMs061927@red.freebsd.org>
Date: Mon, 7 Jan 2013 15:04:20 GMT
From: Tatsuki Makino <tatsuki_makino@hotmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: conf/175105: /etc/rc.d/* and more: syntax 'return_boolean_cmd &&
 do_cmd_if_true' executed last returns unexpected value
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2013 15:10:01 -0000


>Number:         175105
>Category:       conf
>Synopsis:       /etc/rc.d/* and more: syntax 'return_boolean_cmd && do_cmd_if_true' executed last returns unexpected value
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 07 15:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Tatsuki Makino
>Release:        FreeBSD 8.3-STABLE i386
>Organization:
>Environment:
FreeBSD T2.test 8.3-STABLE FreeBSD 8.3-STABLE #0 r245032M: Fri Jan  4 07:36:05 UTC 2013     root@T2.test:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
If the shell script that has 'false && true' line, $? set not 0. If that line execute last, then shell script returns not 0.

sub probrem: conf/175006
>How-To-Repeat:
# echo 'ip6addrctl_verbose="NO"' >> /etc/rc.conf
# /etc/rc.d/ip6addrctl start
# echo $?

# echo 'sysvipc_enable="NO"' >> /etc/rc.conf
# echo 'linux_enable="NO"' >> /etc/rc.conf
# echo 'svr4_enable="NO"' >> /etc/rc.conf
# /etc/rc.d/abi start
# echo $?
>Fix:
1. Use `if' syntax.

if checkyesno foo ; then
  do_foo
fi

1. Execute `true' if false

checkyesno foo && do_foo || true

# If we need result of do_foo
! checkyesno foo && true || do_foo

>Release-Note:
>Audit-Trail:
>Unformatted: