Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 07 Jan 2006 18:38:14 -0800
From:      Sam Leffler <sam@errno.com>
To:        Gary Palmer <gpalmer@freebsd.org>
Cc:        freebsd-stable@freebsd.org
Subject:   Re: devd and caseful device ID matching on 6.0
Message-ID:  <43C07B16.7050505@errno.com>
In-Reply-To: <43C05270.60106@freebsd.org>
References:  <43C05270.60106@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Gary Palmer wrote:
> Hi Warner,
> 
> I've been playing with devd and noticed that if you do something like:
> 
> #
> # Dell TrueMobile 1300 WLAN PC Card
> #
> nomatch 10 {
>        match "bus" "pci[0-9]+";
>        match "vendor" "0x14E4";
>        match "device" "0x4320";
>        match "subvendor" "0x1028";
>        match "subdevice" "0x0002";
>        action "kldload BCMWL5_SYS";
> };
> 
> it won't match (at least on 6.0) as the regex that is used is case 
> sensitive.  Since these are hex numbers, could the comparison not be 
> case insensitive?  I'm not sure what implications just making the regex 
> case insensitive will have on other matching clauses (e.g. for "system").

At one point I added shorthand logic in devd for things like vendor, 
device, subvendor, etc. that did numeric comparisons instead of regex's. 
  It might be worthwhile to extend the grammar to have a numeric match 
operator.

	Sam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43C07B16.7050505>