From owner-svn-src-head@FreeBSD.ORG  Thu Aug 22 10:07:04 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 27582D6B
 for <svn-src-head@freebsd.org>; Thu, 22 Aug 2013 10:07:04 +0000 (UTC)
 (envelope-from mailer-daemon@vniz.net)
Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id B3D502ED1
 for <svn-src-head@freebsd.org>; Thu, 22 Aug 2013 10:07:03 +0000 (UTC)
Received: by mail-ee0-f41.google.com with SMTP id d17so805605eek.0
 for <svn-src-head@freebsd.org>; Thu, 22 Aug 2013 03:06:55 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:openpgp:content-type
 :content-transfer-encoding;
 bh=qCMOGWCpLQLRSJlWy2A2M8oXc6/uZoesOaLH+Otb4bY=;
 b=kWiBJwJh2+IneVCmbWHpP6d3LpXV+GqkeQ9H3DPRdUHtNZUihnaETCs+arYcOS8Ycm
 CNfnYwrPskHBDuaEdzg4vmR/YzeTMIWACvjdHwFskBxEwbm1HtkDUsqV0/Il8YAwRp4i
 2ntj+DjOzxvp+YMEx5xjT5AqogFBKzUlBLtSjb5dY43LPkqvH2Trl5RhJECiVOVFYzE/
 6J1J6Vup3bu9zbtmZjFkbmuSf7DlUdfkJQDKKVh6vik7Pbo/msmyfq1sc/x4V70gojYP
 QPtBkYffqDkKcpApHDFLmq67X2f9WYRmwurz3uwxu+dwe7mS4/Ys6BdyNnqmNSwLS+ui
 rLpQ==
X-Gm-Message-State: ALoCoQmDVCZIj6MpkUwdHkaf1VcicU3KA3FA0EmD73dsM+3lQFNEeY+GvutK7J653KULczfm2H3E
X-Received: by 10.14.115.133 with SMTP id e5mr17642449eeh.27.1377166015729;
 Thu, 22 Aug 2013 03:06:55 -0700 (PDT)
Received: from [192.168.1.2] ([89.169.173.68])
 by mx.google.com with ESMTPSA id b45sm16400984eef.4.1969.12.31.16.00.00
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Thu, 22 Aug 2013 03:06:55 -0700 (PDT)
Message-ID: <5215E2BC.3070904@freebsd.org>
Date: Thu, 22 Aug 2013 14:06:52 +0400
From: Andrey Chernov <ache@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Jilles Tjoelker <jilles@stack.nl>
Subject: Re: svn commit: r254600 - head/lib/libutil
References: <201308211646.r7LGk6eV051215@svn.freebsd.org>
 <5214F72B.7070006@freebsd.org> <20130821190309.GB52908@omg>
 <20130821202725.GA4991@stack.nl> <20130821212413.GC52908@omg>
 <20130821213755.GA8052@stack.nl> <5215E16E.4080207@freebsd.org>
In-Reply-To: <5215E16E.4080207@freebsd.org>
OpenPGP: id=964474DD
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Sergey Kandaurov <pluknet@freebsd.org>, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Aug 2013 10:07:04 -0000

On 22.08.2013 14:01, Andrey Chernov wrote:
> On 22.08.2013 1:37, Jilles Tjoelker wrote:
>>>         if (number == UINTMAX_MAX && errno == ERANGE) {
>>>                 return (-1);
>>>         }
>>>  
>>> +       if (errno == 0)
>>> +               errno = saved_errno;
>>> +
>> This looks good to me.
>>
> 
> Just being nitpicking) number == UINTMAX_MAX check is unneeded.
> 
Sorry for misguiding, forget it.
The check is needed, other functions inside strtoumax() (FIX_LOCALE,
isspace) may set errno in theory.

-- 
http://ache.vniz.net/
bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r