From owner-freebsd-bugs@FreeBSD.ORG Fri Feb 19 12:40:02 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE859106566B for ; Fri, 19 Feb 2010 12:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CDEE68FC13 for ; Fri, 19 Feb 2010 12:40:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o1JCe2CI076938 for ; Fri, 19 Feb 2010 12:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o1JCe2H7076937; Fri, 19 Feb 2010 12:40:02 GMT (envelope-from gnats) Date: Fri, 19 Feb 2010 12:40:02 GMT Message-Id: <201002191240.o1JCe2H7076937@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Ruslan Ermilov Cc: Subject: Re: conf/144079: Makefile.inc1 ${DESTDIR} make dependency enhancement X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ruslan Ermilov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2010 12:40:03 -0000 The following reply was made to PR conf/144079; it has been noted by GNATS. From: Ruslan Ermilov To: Garrett Cooper Cc: bug-followup@FreeBSD.org Subject: Re: conf/144079: Makefile.inc1 ${DESTDIR} make dependency enhancement Date: Fri, 19 Feb 2010 15:38:02 +0300 Garrett, On Thu, Feb 18, 2010 at 11:30:03PM +0000, Garrett Cooper wrote: > The patch on the right track, I don't think so. Our install-related targets never create directories themselves; instead, they expect them to be pre- created, e.g. by mtree. > but wasn't complete, so I had to be > a bit more invasive with where the DESTDIR dependencies went (filled > in all missing dependencies based on inspection) and where the goal > itself goes (bsd.own.mk). > I'm not happy about the placement of the goal, and I'm open to > move it to another location if one exists, as bsd.own.mk seems to be > purely variable driven data setting without goals. Why all this churn, what are you trying to achieve? Save one mkdir command? Why the proposed ${DESTDIR} dependency only covers etc/, include/, and sys/modules/ makefiles? -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer