From owner-freebsd-bugs@FreeBSD.ORG Sat Jan 12 13:10:02 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50D0416A468 for ; Sat, 12 Jan 2008 13:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2014313C455 for ; Sat, 12 Jan 2008 13:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0CDA1bx065865 for ; Sat, 12 Jan 2008 13:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0CDA1do065864; Sat, 12 Jan 2008 13:10:01 GMT (envelope-from gnats) Resent-Date: Sat, 12 Jan 2008 13:10:01 GMT Resent-Message-Id: <200801121310.m0CDA1do065864@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dominic Fandrey Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7B7216A41B for ; Sat, 12 Jan 2008 13:04:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 8E44013C46E for ; Sat, 12 Jan 2008 13:04:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m0CD3R19035862 for ; Sat, 12 Jan 2008 13:03:27 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m0CD3RCh035861; Sat, 12 Jan 2008 13:03:27 GMT (envelope-from nobody) Message-Id: <200801121303.m0CD3RCh035861@www.freebsd.org> Date: Sat, 12 Jan 2008 13:03:27 GMT From: Dominic Fandrey To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/119593: [patch][multimedia/mplayer] allow building with distcc and ccache X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2008 13:10:02 -0000 >Number: 119593 >Category: misc >Synopsis: [patch][multimedia/mplayer] allow building with distcc and ccache >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jan 12 13:10:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Dominic Fandrey >Release: RELENG_7 >Organization: private >Environment: FreeBSD homeKamikaze.norad 7.0-BETA4 FreeBSD 7.0-BETA4 #0: Sun Dec 16 15:44:56 CET 2007 root@homeKamikaze.norad:/usr/obj/VECTRA-7/i386/usr/src/sys/VECTRA-7 i386 >Description: The port sets CC in a fashion that is not space safe, so if CC is defined with distcc and or ccache the mplayer configure script will fall back to the default. The patch removes the faulty lines and so lets configure get CC an AR through the environment, which supplies the correct values due to the usual bsd.port.mk magic. >How-To-Repeat: # cd /usr/ports/mplayer # make CC="ccache distcc cc" >Fix: diff -Pur multimedia/mplayer.orig/Makefile.shared multimedia/mplayer/Makefile.shared --- multimedia/mplayer.orig/Makefile.shared 2008-01-12 12:35:12.000000000 +0100 +++ multimedia/mplayer/Makefile.shared 2008-01-12 12:58:46.000000000 +0100 @@ -29,9 +29,7 @@ CONFIGURE_ENV= PTHREAD_CFLAGS="${PTHREAD_CFLAGS}" \ PTHREAD_LIBS=${PTHREAD_LIBS} \ TMPDIR="${WRKSRC}" -CONFIGURE_ARGS= --cc=${CC} \ - --as=${AS} \ - --enable-png \ +CONFIGURE_ARGS= --enable-png \ --enable-menu \ --disable-faad-external \ --disable-vidix-external \ >Release-Note: >Audit-Trail: >Unformatted: