Date: Sun, 24 Mar 2024 13:27:17 +0100 From: Michael Gmelin <grembo@freebsd.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d79ba67c4595 - main - devel/phorgeit-arcanist-lib: New port Message-ID: <E91B02BE-B099-4664-B6EA-F666FA0591BF@freebsd.org> In-Reply-To: <0984e02f827dea473a52c5b6475aa108@mail.infomaniak.com> References: <0984e02f827dea473a52c5b6475aa108@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Thanks for pointing out that I removed that line by accident, fixed. Portversion is because this is the date this port was actually done. The remaining issues will be addressed (if required) asap, definitely before= cutting 2024Q2 (this was based on existing ports and is not perfect yet). I= might fix the existing ports as well while I=E2=80=99m there. Are you wearing any hat or is this due to a personal interest in the quality= of the ports tree (good!) or specifically my commits (which would be weird)= ? Again, thanks for pointing out the removed line, shouldn=E2=80=99t have happ= ened. Cheers > On 24. Mar 2024, at 12:10, Daniel Engberg <daniel.engberg.lists@pyret.net>= wrote: >=20 > =EF=BB=BFHi, >=20 > Why did this remove "- SUBDIR +=3D php-Psr_Log" in devel/Makefile ? >=20 > Please follow Porters Handbook when it comes to versioning and usage of va= riables. >=20 > Commit refers to https://github.com/phorgeit/arcanist/commit/174bf094ef9fe= 26770903c912cf29b6c78760b26 which was committed, Date: Wed, 28 Feb 2024 12:2= 9:14 +0100 >=20 > Why does PORTVERSION say 20240304? > Upstream uses tags so utilize those and do backports of needed unless you n= ever intend to follow upstream, in that case you should use commit date and p= refix g. > See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-mast= er_sites-github >=20 > Use DISTVERSION whenever possible as shown in examples. please use the sam= e length of commits when using GH_TAGNAME as shown in Porters Handbook. >=20 > Best regards, > Daniel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E91B02BE-B099-4664-B6EA-F666FA0591BF>