From owner-freebsd-rc@FreeBSD.ORG  Sun Oct  7 16:13:36 2007
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1855D16A41A
	for <freebsd-rc@freebsd.org>; Sun,  7 Oct 2007 16:13:36 +0000 (UTC)
	(envelope-from maksim.yevmenkin@gmail.com)
Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184])
	by mx1.freebsd.org (Postfix) with ESMTP id 9BC1413C469
	for <freebsd-rc@freebsd.org>; Sun,  7 Oct 2007 16:13:34 +0000 (UTC)
	(envelope-from maksim.yevmenkin@gmail.com)
Received: by nf-out-0910.google.com with SMTP id b2so771298nfb
	for <freebsd-rc@freebsd.org>; Sun, 07 Oct 2007 09:13:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	bh=hEXdAydYPpB6Kq0+9hF9EIIOqWYaW+5FIgPoQsy6MDI=;
	b=ZjGaIFs9X9I1hDIM/iUP3E3aLm5TlABb/VCVyQdW0DMbwyTRXXeI4Evrwcr9WNonNz05L3w5QzAwPMivz9gyM5hae2qsO4I0dCcEwRvtBrghN8B/eW+WqqA1dbPr1+Gsa3oGepXhYJ2SxGVpdUCxzlUASKDGXQnA+m5wHOE5t2U=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=k/F6+gDMtBgtvXnUagdPsE3PtEvV+4fT6kiMNHZis/Bz8KB9tqdoIEfsbhsSKWRBsJ6MI6+avc6hRQDO5aLjBZPYhkC+RE9UEM/BppaaZtuSiuEJOmAivzc2BoIumsOJEFRCbIGhb0yToKhlIFQ4yKJlfST80n2AWMNJ4glP5mA=
Received: by 10.86.49.13 with SMTP id w13mr4338902fgw.1191773583832;
	Sun, 07 Oct 2007 09:13:03 -0700 (PDT)
Received: by 10.86.25.9 with HTTP; Sun, 7 Oct 2007 09:13:03 -0700 (PDT)
Message-ID: <bb4a86c70710070913w158343e3l3eba7bea64c29c91@mail.gmail.com>
Date: Sun, 7 Oct 2007 09:13:03 -0700
From: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com>
To: "Mike Makonnen" <mtm@freebsd.org>
In-Reply-To: <20071007110815.GA16458@terra.mike.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <bb4a86c70710061314j588ce9a9s6922d2c1e7100e6a@mail.gmail.com>
	<20071006215757.GA10458@terra.mike.lan>
	<bb4a86c70710061549o14447dfye9553a42ef77cadc@mail.gmail.com>
	<20071007110815.GA16458@terra.mike.lan>
Cc: freebsd-rc@freebsd.org
Subject: Re: multiple instances of ppp
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Oct 2007 16:13:36 -0000

Mike,

On 10/7/07, Mike Makonnen <mtm@freebsd.org> wrote:
> On Sat, Oct 06, 2007 at 03:49:57PM -0700, Maksim Yevmenkin wrote:
> >
> > thanks for your comments. what do you think about something like
> >
> > # PROVIDE: ppp
> > # REQUIRE: netif isdnd
> > # KEYWORD: nojail
> >
> > . /etc/rc.subr
> >
> > name="ppp"
> > rcvar=`set_rcvar`
> > command="/usr/sbin/${name}"
> > start_cmd="ppp_start"
> > start_postcmd="ppp_poststart"
> >
> > ppp_start_profile()
> > {
> >       local _ppp_profile, _ppp_mode, _ppp_nat
>
> You should lose the commas. Local variable declarations are space-separated.
>
> Other than that, looks good.

thanks! i have made a patch and submitted it to re@ for approval.

thanks,
max