From owner-freebsd-bugs@FreeBSD.ORG Sat Sep 22 05:20:01 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D82B416A41B for ; Sat, 22 Sep 2007 05:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A1D3213C465 for ; Sat, 22 Sep 2007 05:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8M5K1Fl064402 for ; Sat, 22 Sep 2007 05:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8M5K1YQ064401; Sat, 22 Sep 2007 05:20:01 GMT (envelope-from gnats) Resent-Date: Sat, 22 Sep 2007 05:20:01 GMT Resent-Message-Id: <200709220520.l8M5K1YQ064401@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eugene Grosbein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 354B516A418 for ; Sat, 22 Sep 2007 05:13:50 +0000 (UTC) (envelope-from eugen@grosbein.pp.ru) Received: from grosbein.pp.ru (grgw.svzserv.kemerovo.su [213.184.64.166]) by mx1.freebsd.org (Postfix) with ESMTP id 9776913C45D for ; Sat, 22 Sep 2007 05:13:49 +0000 (UTC) (envelope-from eugen@grosbein.pp.ru) Received: from grosbein.pp.ru (localhost [127.0.0.1]) by grosbein.pp.ru (8.14.1/8.14.1) with ESMTP id l8M5DlnX002007 for ; Sat, 22 Sep 2007 13:13:47 +0800 (KRAST) (envelope-from eugen@grosbein.pp.ru) Received: (from eugen@localhost) by grosbein.pp.ru (8.14.1/8.14.1/Submit) id l8M5DlQw002006; Sat, 22 Sep 2007 13:13:47 +0800 (KRAST) (envelope-from eugen) Message-Id: <200709220513.l8M5DlQw002006@grosbein.pp.ru> Date: Sat, 22 Sep 2007 13:13:47 +0800 (KRAST) From: Eugene Grosbein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/116536: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eugene Grosbein List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Sep 2007 05:20:01 -0000 >Number: 116536 >Category: kern >Synopsis: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Sep 22 05:20:00 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Eugene Grosbein >Release: FreeBSD 6.2-STABLE i386 >Organization: Svyaz-Service JSC >Environment: System: FreeBSD grosbein.pp.ru 6.2-STABLE FreeBSD 6.2-STABLE #2: Sun Sep 16 16:54:23 KRAST 2007 eu@grosbein.pp.ru:/home/obj/usr/local/src/sys/DADV i386 >Description: Changing hint.fd.0.flags has no effect on fdc(4) >How-To-Repeat: Try to change hint.fd.0.flags and see no change in behavour >Fix: --- sys/dev/fdc/fdc.c.orig 2007-09-15 16:53:23.000000000 +0800 +++ sys/dev/fdc/fdc.c 2007-09-16 16:26:07.000000000 +0800 @@ -1848,6 +1864,7 @@ fd->dev = dev; fd->fdc = fdc; fd->fdsu = fdsu; + fd->flags = flags; unit = device_get_unit(dev); /* Auto-probe if fdinfo is present, but always allow override. */ @@ -1857,7 +1874,7 @@ goto done; } else { /* make sure fdautoselect() will be called */ - fd->flags = FD_EMPTY; + fd->flags |= FD_EMPTY; fd->type = type; } >Release-Note: >Audit-Trail: >Unformatted: