From nobody Tue Jul 7 11:30:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gvfCj0ckyz6dRPb for ; Tue, 07 Jul 2026 11:30:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gvfCh30HRz3M5B for ; Tue, 07 Jul 2026 11:30:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783423808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XbmOqX+Poeit/+Oh8+qlvYYKBmfKHjMZtgZM8VtxYRA=; b=lB5tDSqUHPkPt/kE+91zfS/KTHTUgeHKCCVGu5JANf/GgEEkrRajr9tNOzsZI5mcXLUeGD q0MNdk1m+aHZaxikPPhNabzcfZoBpLG1U0B3tznaitStea+0hbEX+0ZGfljmRsubYQCJ/O 8mthGPtPkUYgBxXUH5O3b2bdLEOuPLv8W1siFoVJ7FlCtxYW/r2BZwlYCpLK2YNuzZwRws mSQAjMkkuFN91gxOK9Pi5fakcGa2dmuyggY2UL29LgK6ltoeA5Cp3rh6cOjloOOESPx8mB bFpvKp2lAQQAFuza5GYiVtqhIOZ1dMFKUHhULwZGF5OKYnUCstYcSmw/v3ivQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783423808; a=rsa-sha256; cv=none; b=RdZnUGTho4V9CxTHLxiCa9xEI6Cg1LoUq90K5zkqa8KjRLGEz0wAlkKpanOxUUnv5VAWOc 4x4yRNPbAqsrXy63lhluit6xAk2C2UP59gLVkBA4FCyjHMK7fC+Y8VAb+p0ZqZo9mSsC78 ptReluIofzc2bGGLOUqwEnVhkDEtOxsz0R5qi2kvI54HHr5MyZypls8j3hhUpjFyNWUOgV 95/89xgc+8xcvxLHSZavB4FzNmKciHUlAonHgzoVSJMd68WKr1vuwCar90WmfWRRwKf8pD 6RJkTIPqoQw7z6xxnGhVE7l/F6wN3jHxU9scMxer8ZiAsKDsDd1ttTWiIuwWVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783423808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XbmOqX+Poeit/+Oh8+qlvYYKBmfKHjMZtgZM8VtxYRA=; b=XBmahxfl/HY0Zxa8FM2ie/Yp0taPxVkwQBcGhBiiJDK7abDo/n5gsWanWA0FFoUdUra0pw sSKA8LWkwRzgKL4vKHR97nSqMbKPzsciwEG2VF6TZyTwMsH8bFUo3D6HtS5BwNzG8GFRlC +zW2wuMcZoeYlIEPqpI6NEkE80jnKUMXSs5G7MY7Hi4GkkPmoVwMYmxF6NtVLmo+uSmoxo rwZSZYT+KiBOTtcSlh5LYnJ8sKB+LOqzf1XfGzDUiKZqWO+PzZxHbo8qkcOTgSvZlL0JN+ klphb+RR2NOk+oYnfF83wY3AfPSBVOQhoSlyWnl4L7WHspgxFp1nJ7/nMhincg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gvfCh1wbgzYqW for ; Tue, 07 Jul 2026 11:30:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36ea0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 07 Jul 2026 11:30:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ariel Ehrenberg From: Konstantin Belousov Subject: git: a7298669cd53 - main - ofed/ib_uverbs: release rdma_user_mmap entry ref in rdma_umap_close() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a7298669cd53a9fc8446c53db6872bc2f64c508d Auto-Submitted: auto-generated Date: Tue, 07 Jul 2026 11:30:08 +0000 Message-Id: <6a4ce340.36ea0.5e342732@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=a7298669cd53a9fc8446c53db6872bc2f64c508d commit a7298669cd53a9fc8446c53db6872bc2f64c508d Author: Ariel Ehrenberg AuthorDate: 2026-06-08 10:56:16 +0000 Commit: Konstantin Belousov CommitDate: 2026-07-07 11:25:23 +0000 ofed/ib_uverbs: release rdma_user_mmap entry ref in rdma_umap_close() Import Linux upstream commit 3411f9f01b76bd88aa6e0e013847ab6479cb4f24. rdma_umap_priv_init() takes a reference on the rdma_user_mmap entry for every VMA it maps, but rdma_umap_close() never dropped it. The entry was therefore never freed and lingered in ucontext->mmap_xa, tripping WARN_ON(!xa_empty(&ucontext->mmap_xa)) at context teardown and leaking the firmware UAR on every context close. Reviewed by: kib Tested by: Wafa Hamzah Sponsored by: Nvidia networking MFC after: 1 month --- sys/ofed/drivers/infiniband/core/ib_uverbs_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/ofed/drivers/infiniband/core/ib_uverbs_main.c b/sys/ofed/drivers/infiniband/core/ib_uverbs_main.c index 1586c23d28d4..42b6d55de56e 100644 --- a/sys/ofed/drivers/infiniband/core/ib_uverbs_main.c +++ b/sys/ofed/drivers/infiniband/core/ib_uverbs_main.c @@ -745,6 +745,8 @@ static void rdma_umap_close(struct vm_area_struct *vma) * this point. */ mutex_lock(&ufile->umap_lock); + if (priv->entry) + rdma_user_mmap_entry_put(priv->entry); list_del(&priv->list); mutex_unlock(&ufile->umap_lock);