From owner-svn-src-head@FreeBSD.ORG  Fri Dec 18 22:19:45 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 57527106566B;
	Fri, 18 Dec 2009 22:19:45 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id F0FB88FC08;
	Fri, 18 Dec 2009 22:19:44 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id nBIM9oa3097158;
	Fri, 18 Dec 2009 15:09:50 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 18 Dec 2009 15:10:17 -0700 (MST)
Message-Id: <20091218.151017.956847443318915404.imp@bsdimp.com>
To: ed@80386.nl
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20091218163626.GF64905@hoeg.nl>
References: <200912161541.53834.jhb@freebsd.org> <868wd0cyjd.fsf@ds4.des.no>
	<20091218163626.GF64905@hoeg.nl>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, jhb@FreeBSD.org
Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Dec 2009 22:19:45 -0000

In message: <20091218163626.GF64905@hoeg.nl>
            Ed Schouten <ed@80386.nl> writes:
: Hello DES,
: =

: First of all: happy birthday!
: =

: * Dag-Erling Sm=F8rgrav <des@des.no> wrote:
: > perhaps we should simply add the appropriate
: > #ifndef / #error constructs so you can't define FREEBSD_COMPAT(n)
: > without FREEBSD_COMPAT(n+1).
: =

: Why not make COMPAT_FREEBSD numerical?
: =

: | options COMPAT_FREEBSD=3D4
: =

: and let the code use:
: =

: | #if COMPAT_FREEBSD <=3D 4
: | ...
: | #endif

That would take some doing to the syscall generation code as well.

The whole concept of the compat stuff isn't well thought out, since it
seems backwards (and I think that you got your example wrong).

Warner