From owner-freebsd-current@FreeBSD.ORG Sun Mar 25 23:37:19 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA9E4106566B; Sun, 25 Mar 2012 23:37:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 04FDC8FC23; Sun, 25 Mar 2012 23:37:18 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q2PNbEXp060723; Mon, 26 Mar 2012 02:37:15 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q2PNbEcx019289; Mon, 26 Mar 2012 02:37:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q2PNbEFa019288; Mon, 26 Mar 2012 02:37:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 26 Mar 2012 02:37:14 +0300 From: Konstantin Belousov To: Tim Kientzle Message-ID: <20120325233714.GF2358@deviant.kiev.zoral.com.ua> References: <4F6CD93D.70109@passap.ru> <4F6CEB1F.4040300@FreeBSD.org> <4F6D52DF.7080105@passap.ru> <4F34E618-DB66-464D-B5B2-900960D6C16B@kientzle.com> <4F6F155E.30902@passap.ru> <38D08B05-58E1-4266-9628-2C22836806D3@kientzle.com> <20120325214327.GA1238@reks> <903ACDC1-CE39-45A5-8F37-9FE9BC969F42@kientzle.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nov/FvmP1ZEqD5bX" Content-Disposition: inline In-Reply-To: <903ACDC1-CE39-45A5-8F37-9FE9BC969F42@kientzle.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Gleb Kurtsou , freebsd-current FreeBSD , pjd@freebsd.org Subject: Re: /usr/bin/tar creates invalid lib file X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2012 23:37:19 -0000 --nov/FvmP1ZEqD5bX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 25, 2012 at 04:32:53PM -0700, Tim Kientzle wrote: >=20 > On Mar 25, 2012, at 2:43 PM, Gleb Kurtsou wrote: >=20 > > I experience a related issue. lseek(SEEK_HOLE) error checks are too > > strict. Files are not added to archive if lseek(SEEK_HOLE) fails. > > Ignoring lseek(SEEK_HOLE) at least in ENOTTY case would be preferable. >=20 > Just noticed that lseek(1) doesn't document ENOTTY as > a valid response code. >=20 > Should it? It seems that man page contradicts the actual lseek(2) behaviour. Man page states that there shall be a virtual hole after file end, even on the filesystems not supporting hole reports. Is there some regression test set for SEEK_HOLE/SEEK_DATA ? I found nothing in our tests, in particular, pjdfstest does not mention the options. --nov/FvmP1ZEqD5bX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9vrCoACgkQC3+MBN1Mb4iHkwCgxrMjIQb0xt59bU7FE4csqJmg XxUAni7+cQNS7DXDSHmOmyEbg+2bFkd1 =cxsP -----END PGP SIGNATURE----- --nov/FvmP1ZEqD5bX--