Date: Mon, 26 Mar 2012 02:37:14 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Tim Kientzle <tim@kientzle.com> Cc: Gleb Kurtsou <gleb.kurtsou@gmail.com>, freebsd-current FreeBSD <freebsd-current@freebsd.org>, pjd@freebsd.org Subject: Re: /usr/bin/tar creates invalid lib file Message-ID: <20120325233714.GF2358@deviant.kiev.zoral.com.ua> In-Reply-To: <903ACDC1-CE39-45A5-8F37-9FE9BC969F42@kientzle.com> References: <4F6CD93D.70109@passap.ru> <4F6CEB1F.4040300@FreeBSD.org> <4F6D52DF.7080105@passap.ru> <4F34E618-DB66-464D-B5B2-900960D6C16B@kientzle.com> <4F6F155E.30902@passap.ru> <38D08B05-58E1-4266-9628-2C22836806D3@kientzle.com> <20120325214327.GA1238@reks> <903ACDC1-CE39-45A5-8F37-9FE9BC969F42@kientzle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nov/FvmP1ZEqD5bX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 25, 2012 at 04:32:53PM -0700, Tim Kientzle wrote: >=20 > On Mar 25, 2012, at 2:43 PM, Gleb Kurtsou wrote: >=20 > > I experience a related issue. lseek(SEEK_HOLE) error checks are too > > strict. Files are not added to archive if lseek(SEEK_HOLE) fails. > > Ignoring lseek(SEEK_HOLE) at least in ENOTTY case would be preferable. >=20 > Just noticed that lseek(1) doesn't document ENOTTY as > a valid response code. >=20 > Should it? It seems that man page contradicts the actual lseek(2) behaviour. Man page states that there shall be a virtual hole after file end, even on the filesystems not supporting hole reports. Is there some regression test set for SEEK_HOLE/SEEK_DATA ? I found nothing in our tests, in particular, pjdfstest does not mention the options. --nov/FvmP1ZEqD5bX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9vrCoACgkQC3+MBN1Mb4iHkwCgxrMjIQb0xt59bU7FE4csqJmg XxUAni7+cQNS7DXDSHmOmyEbg+2bFkd1 =cxsP -----END PGP SIGNATURE----- --nov/FvmP1ZEqD5bX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120325233714.GF2358>