From owner-cvs-all@FreeBSD.ORG Fri Sep 24 07:27:31 2010 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62E1C106566C for ; Fri, 24 Sep 2010 07:27:31 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 070528FC17 for ; Fri, 24 Sep 2010 07:27:30 +0000 (UTC) Received: (qmail 4184 invoked by uid 399); 24 Sep 2010 07:27:30 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 24 Sep 2010 07:27:30 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C9C52E0.2040507@FreeBSD.org> Date: Fri, 24 Sep 2010 00:27:28 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: "Sergey A. Osokin" References: <4C9C4CDB.9000706@FreeBSD.org> <20100924071832.GB72615@FreeBSD.org> In-Reply-To: <20100924071832.GB72615@FreeBSD.org> X-Enigmail-Version: 1.2a1pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@freebsd.org, "Philip M. Gollucci" , cvs-all@freebsd.org, Andrej Zverev , ports-committers@freebsd.org Subject: Re: cvs commit: ports/archivers/p5-Archive-Any pkg-plist ports/archivers/p5-Archive-SimpleExtractor pkg-plist ports/archivers/p5-Compress-LZF pkg-plist ports/archivers/p5-Compress-LZO pkg-plist ports/archivers/p5-Compress-LZW pkg-plist ports/archiver X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2010 07:27:31 -0000 On 9/24/2010 12:18 AM, Sergey A. Osokin wrote: > On Fri, Sep 24, 2010 at 12:01:47AM -0700, Doug Barton wrote: >> On 9/23/2010 10:39 PM, Andrej Zverev wrote: >>> Log: >>> - only 13% of the p5- ports embed @comment $FreeBSD$: >>> so standarize and remove it >>> >>> How about to explain the benefits of this? >> >> Speaking only for myself ... >> >> 1. Standardization is a good thing since so much stuff is copy/pasted > > Could you please describe standards and vote before doing anything. Thank you. I think Philip described the standard very well in the portion of the log that is quoted above. Personally, I've never seen or used such a comment in any FreeBSD port, and can't imagine any reason why someone would want to. >> 2. The comments that were removed added no value, so > > This commit also have no additional value too. Thank you again. It made the ports tree a little smaller? And personally I think more standardization is a good thing in areas that have no material effect on the port, or the maintainer's creativity. >> 3. There was no harm in removing them. >> >> Philip may have additional/better answers. >> Do you have a specific concern about them being removed, or were you >> just curious? > > I'm totally disagree with Philip mass-commits as well as implicit approval from portmgrs. This sounds to me like a personality and/or perspective problem, more than a technical one. If you'd like to raise a _technical_ issue with the commit (as in, something that worked previously no longer does) then this list is probably the right one to do that. If you have a personality or other non-technical issue, perhaps you'd be better off raising it privately, or with portmgr@. FWIW, Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/