From owner-cvs-all Wed Aug 28 15:33:37 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A8CF37B400; Wed, 28 Aug 2002 15:33:32 -0700 (PDT) Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FAC043E6A; Wed, 28 Aug 2002 15:33:31 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from mail.lan.Awfulhak.org (brian@hak.Awfulhak.org [IPv6:2001:6f8:602:1::12]) by Awfulhak.org (8.12.5/8.12.5) with SMTP id g7SMXOSw015319; Wed, 28 Aug 2002 23:33:28 +0100 (BST) (envelope-from brian@Awfulhak.org) Date: Wed, 28 Aug 2002 23:32:37 +0100 From: Brian Somers To: "Bruce Evans" Cc: brian@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/ppp bundle.c ccp.c command.c datalink.c filter.c hdlc.c iface.c ipcp.c ipv6cp.c lcp.c link.c main.c mbuf.c mp.c nat_cmd.c ncp.c physical.c prompt.h radius.c ro Message-Id: <20020828233237.59fb0621.brian@Awfulhak.org> In-Reply-To: <20020828130240.P2884-100000@gamplex.bde.org> References: <200208272012.g7RKC07e087329@freefall.freebsd.org> <20020828130240.P2884-100000@gamplex.bde.org> X-Mailer: Sylpheed version 0.7.8claws (GTK+ 1.2.10; i386-portbld-freebsd5.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG The only excuse I have for this is consistency, and that's not a very good excuse in this context. I'll try to address this sometime soon. On Wed, 28 Aug 2002 13:20:47 +1000 (EST), Bruce Evans wrote: > On Tue, 27 Aug 2002, Brian Somers wrote: > > > brian 2002/08/27 13:12:00 PDT > > > > Modified files: > > usr.sbin/ppp bundle.c ccp.c command.c datalink.c > > filter.c hdlc.c iface.c ipcp.c ipv6cp.c > > lcp.c link.c main.c mbuf.c mp.c nat_cmd.c > > ncp.c physical.c prompt.h radius.c > > route.c server.c slcompress.c > > throughput.c timer.c > > Log: > > Include the correct file (stdarg.h) and use va_list rather than _BSD_VA_LIST_ > > > > Suggested by: mike > > This is hardly cleaner. Now almost every .c file has to include > to support a detail in prompt.h, despite only 2 .c files actually using that > detail. Those 2 already included . > > Bruce > > -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message