From owner-freebsd-current@FreeBSD.ORG Wed Sep 23 14:37:56 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F527106566B for ; Wed, 23 Sep 2009 14:37:56 +0000 (UTC) (envelope-from barney_cordoba@yahoo.com) Received: from n3a.bullet.mail.ac4.yahoo.com (n3a.bullet.mail.ac4.yahoo.com [76.13.13.66]) by mx1.freebsd.org (Postfix) with SMTP id 53DF68FC13 for ; Wed, 23 Sep 2009 14:37:56 +0000 (UTC) Received: from [76.13.13.26] by n3.bullet.mail.ac4.yahoo.com with NNFMP; 23 Sep 2009 14:37:55 -0000 Received: from [76.13.10.180] by t3.bullet.mail.ac4.yahoo.com with NNFMP; 23 Sep 2009 14:37:55 -0000 Received: from [127.0.0.1] by omp121.mail.ac4.yahoo.com with NNFMP; 23 Sep 2009 14:37:55 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 748511.75712.bm@omp121.mail.ac4.yahoo.com Received: (qmail 9630 invoked by uid 60001); 23 Sep 2009 14:36:22 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1253716581; bh=ildQeV0b13R9IZWNekUzN3cLisyiqYAogNGpHg7lHnw=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=dYF7Evyp+MnulxiYd1SjVWdiZcrSJm1Rh1O/aBhS61PgAdB1fG+cm5YXgkvZjhWXHCbNQ4Z1uXHJgjAQ1lVMRBeZjZEtFOp/WfMjxyqg00JQExp2BXjvLbPNVUjjS47csAL0asU8szLtYL1sLCBZl6TrwToBL4Cc04Dz81z2jg4= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=OJFpxOf4dm0Ffevb/DUsQJCexIV/VHEvkGpm8YOLQIC6WTKRSf08Jd9J4FIq97iu52kBaQDaV1pjgwY1MdQTNpes4qxUOwvSsXubVPiEwAEitlATdrfVFaNBirwqkhXHIQ3njkOgXrUz4jH9WueVOFDcBmafNJGp7yQAemKzSH8=; Message-ID: <961251.9294.qm@web63906.mail.re1.yahoo.com> X-YMail-OSG: O0_UNZ4VM1m9V8XlvVguNpM0ugbtBlCCor6J2DAKBo9Y6gV4J7pSOGEOmRIIe66Ahh7yjoJgLGfZIfJUZtAL2O_KnZ65K22y7JRmD9zvGyxriX4wvZsXGVIdi5kZ3rqmKiAwyIZrJq3vvlaofcR6qIbVJibrTSp6pjAJ0O1ubuG3A4xrSMAnitOv5Nt7w62BQNLM15PFOLRXITLmHC6wR5JfQeM.TAlXL1EiuEU6Bjy4F.8bEgJ07PzEZ7okvIdGx7TZm4wBFMPtW0UkfL1yfUCxPCXAzPAziYrAuu21t9FwFWI- Received: from [98.203.21.152] by web63906.mail.re1.yahoo.com via HTTP; Wed, 23 Sep 2009 07:36:21 PDT X-Mailer: YahooMailClassic/7.0.14 YahooMailWebService/0.7.347.2 Date: Wed, 23 Sep 2009 07:36:21 -0700 (PDT) From: Barney Cordoba To: Stefan Ehmann , Andriy Gapon In-Reply-To: <4ABA0DC5.6070502@icyb.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, pluknet Subject: Re: where is device_get_parent function defined X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2009 14:37:56 -0000 =0A=0A--- On Wed, 9/23/09, Andriy Gapon wrote:=0A=0A> Fro= m: Andriy Gapon =0A> Subject: Re: where is device_get_pare= nt function defined=0A> To: "Stefan Ehmann" =0A> Cc: free= bsd-current@freebsd.org, "Barney Cordoba" , "pluk= net" =0A> Date: Wednesday, September 23, 2009, 8:00 AM= =0A> on 22/09/2009 23:44 Stefan Ehmann=0A> said the following:=0A> > On Tue= sday 22 September 2009 16:21:54 Barney Cordoba=0A> wrote:=0A> >> --- On Tue= , 9/22/09, pluknet =0A> wrote:=0A> > ...=0A> >>> Followi= ng style(9):=0A> >>> ###=0A> >>>=A0 =A0 =A0 The function type should=0A> be= on a=0A> >>> line by itself preceding the function.=0A> >>>=0A> >>>=A0 =A0= =A0 static char *=0A> >>>=A0 =A0 =A0 function(int a1, int a2,=0A> float fl= ,=0A> >>> int a4)=0A> >>> ###=0A> >>>=0A> >>> So you can safely use the car= et sign in regex:=0A> grep=0A> >>> ^keyword path=0A> >> Except for the 50K = recursive warnings from the=0A> module build directories=0A> >> you're corr= ect.=0A> > =0A> > In that case, I normally use:=0A> > find /usr/src/ -type = f | xargs grep=0A> ^device_get_parent=0A> > =0A> > Additionally specifying = -name '*.c' should even be=0A> faster.=0A> > =0A> =0A> I am surprised with = this whole 'recursive' issue because in=0A> a clean source tree=0A> there a= re no recursive symlinks. They only come to be if a=0A> developer forgets t= o=0A> run 'make obj' before doing 'make' in modules directories.=0A> I thin= k that it is a good practice to never pollute the=0A> source tree with buil= d=0A> objects, they should belong to /usr/obj or equivalent.=0A=0AIf you ma= ke modules from the module directory (rather than a full=0Amake in the kern= el build directory) then you are not using the exact =0Asame switches, as I= understand it. I had the problem with a witness =0Akernel and it was quite= a disaster.=0A=0Abarney=0A=0A=0A