From owner-freebsd-current@FreeBSD.ORG Fri Jul 15 21:39:40 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22AEC16A41C; Fri, 15 Jul 2005 21:39:40 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id C77BC43D46; Fri, 15 Jul 2005 21:39:39 +0000 (GMT) (envelope-from nate@root.org) Received: from [192.168.52.136] (ip-207-145-88-3.nyc.megapath.net [207.145.88.3]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j6FLdco5026080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 15 Jul 2005 14:39:39 -0700 Message-ID: <42D82B32.6090707@root.org> Date: Fri, 15 Jul 2005 14:31:30 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <4.3.2.7.2.20050712134818.0202b0d0@mail.qconline.com> <4.3.2.7.2.20050712150444.01fb8078@mail.qconline.com> <200507121627.44317.jhb@FreeBSD.org> In-Reply-To: <200507121627.44317.jhb@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org, Harry Coin Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x acpi and up X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2005 21:39:40 -0000 John Baldwin wrote: > On Tuesday 12 July 2005 04:12 pm, Harry Coin wrote: > >>John, >> >>I am sincerely appreciative the time you have taken. Your test results >>are below. >> >>I haven't processed everything you've written, but I'm not going to hold >>you up waiting as that is going to take a while. >> >>The code just comments out the line you mentioned. pcm0 loads with ACPI on >>in this case. I haven't tested what happens with ACPI off, and have no >>easy way to test what will happen with the other non-pnp chips (or other >>pnp chips) this driver supports. > > > Ok, thanks. > > >>I suggest you send a copy of your comments to whoever fixes up the >>architecture manual, because of evident disagreement regarding best >>practice in the isa non-pnp driver detection method (ISA_PNP_PROBE vs. >>isa_get_logical_id). > > > Well, I think I've just figured out why it says that (the ACPIxxxx devices), > so it looks like I am going to have to go through and fix all the various > drivers to use a probe routine if they attach to ACPI. It looks like several > drivers attach to acpi that probably don't need to as well (ACPI only > enumerates built-in hardware like COM ports, etc. It doesn't enumerate ISA > PnP cards). Thanks for looking into this. I agree that only the PNP-capable probe should attach to acpi. -- Nate