Date: Mon, 19 Mar 2012 20:44:56 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Ade Lovett <ade@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: [PATCH] proposal for x11-wm/windowmaker Message-ID: <4F67FD38.7010006@FreeBSD.org> In-Reply-To: <4F67C74D.2080906@FreeBSD.org> References: <20120319075901.GA16256@snail.casa> <4F67BE27.7030400@FreeBSD.org> <4F67C74D.2080906@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/19/2012 4:54 PM, Ade Lovett wrote: > On 3/19/2012 16:15, Doug Barton wrote: >> On 3/19/2012 12:59 AM, Arrigo Marchiori wrote: >>> Hello, >>> >>> I am attaching a "quick-and-dirty" patch that should reallow >>> compilation of x11-wm/windowmaker under 7-STABLE. >>> >>> The problem seems to be the missing macro HAVE_SYS_SELECT_H; the patch >>> just forces it in the configure script if a FreeBSD system is >>> detected. >> >> I'm not opposed to adding that if someone can confirm that it allows >> WindowMaker to compile on 7-stable. > > Since it's for 7-stable only (apparently), it would be better off > wrapped in an OSVERSION check to make things abundantly clear as to why > it's being done. Yes, I was planning to do that, but thanks for the suggestion in any case. -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F67FD38.7010006>