From nobody Thu Feb 5 14:14:39 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f6K3g3xFqz6QbdL for ; Thu, 05 Feb 2026 14:14:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f6K3g3GYjz3Cgx for ; Thu, 05 Feb 2026 14:14:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770300879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lu4UYqbs1qzVJLGCSm6ayFcJ7gwFyFcX0++VMjugpYU=; b=AJfCqMutCsfg7MWpgFJModCdXP3wpt9nAEcqG6vepCfbJnwN4KfVgeki2YywKKmt7xG2NC ZTZC8bGWBUw0j1n15ypej7jW5qvDwSyauvWq0z0IhagDlY8E/UMBvtBABZvQ2k3yNRLSVb I9pCH1JTrRMrfiAugly1kf091YGyLeBcSc3vEdkZ+Rnfnl7Z2j/ov722iz6/g8lThAsvFm OkPQRMBDZHbXWYcmYsY9/nfrKq0DggXYBGzFKU/v3xzVDYbbEsbxHR6qQ2OEKhyMkKk+zu 73GpvDnKFYnDElbkLFaPZoswPSX0yShlfVArEBePcx7AaaxnxAe1uAR60ttCew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770300879; a=rsa-sha256; cv=none; b=ntCJN6W1fd7779Dk1oyVSItvSPhXcuajIq4BZ6+lwchgR34+VcIiQIRMj7afqhbSHsdlj4 LEFoqKe6U68LkDrqyBuQmrQzk+zbfpXIfB8UZtQEUGaZFXJ7sIB9vvJRFwBObPyq2OWyY/ lJqRvBHOCflF/oUmNCp5R+MeMVg1JIu0IvtXypU/rqsJF4lmg1U7v/NuYo6ozBR3aOcBWg 4tjATIA1W0XK3PxuzmlZZFetdNGtt86SuOmeq3szdPIUlwl5+IJvHV3D1wJglHSdUzIMAj QYry/Ol1xevoW43qKoLIyLuiqH7i5cKLF2kHRDbWmKHbAI+OEHKXjM9oAOVf8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770300879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lu4UYqbs1qzVJLGCSm6ayFcJ7gwFyFcX0++VMjugpYU=; b=wmOYIdEq1YA7RLO/84hcv1m81mHoIaqfC3xYLKGFsF10ixhvbBLjOuhl1qtWM1HBKk2nND zSjCY3k5Y1mSjtf9M/LhrLeVPqW45RQjLfGKAnVDtv/46ZTC7nHtj89p2s+HG8EMq3rptD 5L7C2T4A0Z6w+DAzVC/2iLkKcc574cb93Bb54bBa+YkMfO0JYHXTdX+5fyDjEkoi3MMZdF pKQ7Zr2lCq5ea1iCFyODU46wOj4NuuYTyp5d76LZADLrDCXT8FTOdZP7xS1O1Ma65mNdK5 mHyVj00d+2wwBK6ajqKVUnEFfzSmDRi27IogEcF/DvIiQ3ihpeCO7M6INN/HZw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f6K3g2pv9zZCN for ; Thu, 05 Feb 2026 14:14:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 371e3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Feb 2026 14:14:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: acazuc From: Ed Maste Subject: git: 2e94e1631ef5 - main - bnxt: set hardware checksum only if required List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2e94e1631ef517f5495e25d7fa22c95f7dca0dc6 Auto-Submitted: auto-generated Date: Thu, 05 Feb 2026 14:14:39 +0000 Message-Id: <6984a5cf.371e3.fcac435@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=2e94e1631ef517f5495e25d7fa22c95f7dca0dc6 commit 2e94e1631ef517f5495e25d7fa22c95f7dca0dc6 Author: acazuc AuthorDate: 2025-11-27 10:29:34 +0000 Commit: Ed Maste CommitDate: 2026-02-05 14:07:49 +0000 bnxt: set hardware checksum only if required The test condition in the bnxt driver for TCP/UDP transmit hardware checksum offload is invalid: only the TCP / UDP csum bits should be tested Only the relevant ipi_csum_flags bits are now tested Reviewed by: tuexen Sponsored by: Stormshield Differential Revision: https://reviews.freebsd.org/D53941 --- sys/dev/bnxt/bnxt_en/bnxt_txrx.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/bnxt_txrx.c b/sys/dev/bnxt/bnxt_en/bnxt_txrx.c index 2e10de6f0174..3e867454de8a 100644 --- a/sys/dev/bnxt/bnxt_en/bnxt_txrx.c +++ b/sys/dev/bnxt/bnxt_en/bnxt_txrx.c @@ -154,12 +154,22 @@ bnxt_isc_txd_encap(void *sc, if_pkt_info_t pi) lflags |= TX_BD_LONG_LFLAGS_LSO | TX_BD_LONG_LFLAGS_T_IPID; } - else if(pi->ipi_csum_flags & CSUM_OFFLOAD) { - lflags |= TX_BD_LONG_LFLAGS_TCP_UDP_CHKSUM | - TX_BD_LONG_LFLAGS_IP_CHKSUM; - } - else if(pi->ipi_csum_flags & CSUM_IP) { - lflags |= TX_BD_LONG_LFLAGS_IP_CHKSUM; + else { + if (pi->ipi_csum_flags & CSUM_IP) { + lflags |= TX_BD_LONG_LFLAGS_IP_CHKSUM; + } + switch (pi->ipi_ipproto) { + case IPPROTO_TCP: + if (pi->ipi_csum_flags & (CSUM_IP_TCP | CSUM_IP6_TCP)) { + lflags |= TX_BD_LONG_LFLAGS_TCP_UDP_CHKSUM; + } + break; + case IPPROTO_UDP: + if (pi->ipi_csum_flags & (CSUM_IP_UDP | CSUM_IP6_UDP)) { + lflags |= TX_BD_LONG_LFLAGS_TCP_UDP_CHKSUM; + } + break; + } } tbdh->lflags = htole16(lflags); }