From owner-svn-src-head@freebsd.org Fri Aug 28 07:48:08 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D30C79C311C; Fri, 28 Aug 2015 07:48:08 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A106921A; Fri, 28 Aug 2015 07:48:08 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacdd16 with SMTP id dd16so54286126pac.2; Fri, 28 Aug 2015 00:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oIREIwSRd67/z63XXNSSnVvuzfGKQgeq3s5ihFGN47E=; b=XvEl4kF7FyaZSMWq3TQx5zHMkvWQOIUAZgN6l0tzeP6TpnNbSfxTX9KORQh2w5vFqC ubPHjRHNBxLpzYgaK5rN18vrx1jwuy8cPkLZ/mkUHbHdjPIb2SkO5oLb/ImTwbR86n/t AadC6LWkuzN+DvEF2AE5bFhe4kZVBbaPhlGma2+zBDbQWtBml5nF1Ios3F/3/S7agV/a v7m/0VSVzvYq/c/4pLxwz9zK8Vgs/3iXLTjHBmJj1rP19fp6xydyAuvD0L5nyBYeJFd0 hgGhj1h9RiSt5MoJAOAafb62PoCWAwyOjohOujng6psuo2PkjZq/jKO1KS/xdML7zGv8 mvyw== X-Received: by 10.66.248.72 with SMTP id yk8mr13072674pac.112.1440748088207; Fri, 28 Aug 2015 00:48:08 -0700 (PDT) Received: from [192.168.20.10] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id hv3sm4727448pbb.83.2015.08.28.00.48.07 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Aug 2015 00:48:07 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r287236 - head/bin/df From: Garrett Cooper X-Mailer: iPhone Mail (12H321) In-Reply-To: Date: Fri, 28 Aug 2015 00:48:07 -0700 Cc: Alexey Dokuchaev , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Xin LI Content-Transfer-Encoding: quoted-printable Message-Id: References: <201508280044.t7S0ixfW038766@repo.freebsd.org> <20150828044312.GA88538@FreeBSD.org> <20150828060458.GA20642@FreeBSD.org> To: "O'Connor, Daniel" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2015 07:48:08 -0000 > On Aug 28, 2015, at 00:24, O'Connor, Daniel wrote: >=20 >> On 28 Aug 2015, at 15:34, Alexey Dokuchaev wrote: >>> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: >>>> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev w= rote: >>>>> On Fri, Aug 28, 2015 at 12:44:59AM +0000, Xin LI wrote: >>>>> New Revision: 287236 >>>>> URL: https://svnweb.freebsd.org/changeset/base/287236 >>>>>=20 >>>>> Log: >>>>> Use exit() instead of return in main(). >>>>=20 >>>> Because?.. >>>=20 >>> Probably because of libxo... >>=20 >> I'm just wondering how hard is it to write sensible commit logs. :( >=20 > To put it in a hopefully more helpful way.. > Please write why your change is doing something, not what it is doing. >=20 > Saying what it is doing is OK if it's really hairy, but 99% of the time th= at isn't the case. >=20 > Assuming this is a libxo thing the commit log should have been something l= ike.. > "Use exit out of main otherwise libxo will not flush properly" > (or something similar) >=20 > Although it would be surprising if libxo required you to use exit().. Libxo (iirc) doesn't install atexit handlers, which means that you need to u= se exit (or a reason facsimile) in order for it to flush its file streams. This is unintuitive though. I wish it did the right thing as part of initial= izing the streams..=