From owner-svn-src-head@freebsd.org Thu Mar 1 15:43:52 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B8B8F364B7; Thu, 1 Mar 2018 15:43:52 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3A1256CFE1; Thu, 1 Mar 2018 15:43:51 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (cpe-75-82-218-62.socal.res.rr.com [75.82.218.62]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id w21Fhgcd001246 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 1 Mar 2018 07:43:43 -0800 Subject: Re: svn commit: r330240 - in head/sys: conf powerpc/conf powerpc/powernv To: Wojciech Macek , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201803011411.w21EB87c087995@repo.freebsd.org> From: Nathan Whitehorn Message-ID: Date: Thu, 1 Mar 2018 07:43:42 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201803011411.w21EB87c087995@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVbZ4Txg5GwOtr6b7Lj+LQD99kbPJj3kUc5xXb01/jv0sXOARsrZXrSEfyS69OMbGwzUpAklZ+ffzFMJMzDdhGGi+fqPhO+9nyE= X-Sonic-ID: C;QJLqUWcd6BG58SAFsE207w== M;dnthUmcd6BG58SAFsE207w== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 15:43:52 -0000 On 03/01/18 06:11, Wojciech Macek wrote: > Author: wma > Date: Thu Mar 1 14:11:07 2018 > New Revision: 330240 > URL: https://svnweb.freebsd.org/changeset/base/330240 > > Log: > PowerNV: Initial support for OPAL I2C transfers > > Add I2C OPAL driver and a set of dummy-ones to allow > all I2C things on Power8 to attach. > > TODO: better async token management > > Submitted by: Wojciech Macek > Obtained from: Semihalf > Sponsored by: IBM, QCM Technologies > > Added: > head/sys/powerpc/powernv/opal_i2c.c (contents, props changed) > head/sys/powerpc/powernv/opal_i2cm.c (contents, props changed) > head/sys/powerpc/powernv/powernv_centaur.c (contents, props changed) > head/sys/powerpc/powernv/powernv_xscom.c (contents, props changed) > Modified: > head/sys/conf/files.powerpc > head/sys/powerpc/conf/GENERIC64 > head/sys/powerpc/powernv/opal.h > > Modified: head/sys/conf/files.powerpc > ============================================================================== > --- head/sys/conf/files.powerpc Thu Mar 1 13:52:18 2018 (r330239) > +++ head/sys/conf/files.powerpc Thu Mar 1 14:11:07 2018 (r330240) > @@ -186,9 +186,13 @@ powerpc/powermac/vcoregpio.c optional powermac > powerpc/powernv/opal.c optional powernv > powerpc/powernv/opal_console.c optional powernv > powerpc/powernv/opal_dev.c optional powernv > +powerpc/powernv/opal_i2c.c optional iicbus fdt powernv > +powerpc/powernv/opal_i2cm.c optional iicbus fdt powernv These don't use FDT functions directly (and shouldn't), so you should remove the fdt part on the right. We only gate on 'options FDT' for things that are really FDT- (as opposed to OF-) specific. > powerpc/powernv/opal_pci.c optional powernv pci > powerpc/powernv/opalcall.S optional powernv > powerpc/powernv/platform_powernv.c optional powernv > +powerpc/powernv/powernv_centaur.c optional powernv > +powerpc/powernv/powernv_xscom.c optional powernv > powerpc/powerpc/altivec.c optional powerpc | powerpc64 > powerpc/powerpc/autoconf.c standard > powerpc/powerpc/bcopy.c standard > > Modified: head/sys/powerpc/conf/GENERIC64 > ============================================================================== > --- head/sys/powerpc/conf/GENERIC64 Thu Mar 1 13:52:18 2018 (r330239) > +++ head/sys/powerpc/conf/GENERIC64 Thu Mar 1 14:11:07 2018 (r330240) > @@ -206,6 +206,7 @@ device fwe # Ethernet over FireWire (non-standard!) > > # Misc > device iicbus # I2C bus code > +device iic Please add a comment here. -Nathan