From owner-freebsd-bugs@freebsd.org Tue Mar 1 20:52:15 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CA8FABEDCD for ; Tue, 1 Mar 2016 20:52:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 81E8B1BE2 for ; Tue, 1 Mar 2016 20:52:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u21KqFA0076848 for ; Tue, 1 Mar 2016 20:52:15 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 207626] Memory leak in ctl.c Date: Tue, 01 Mar 2016 20:52:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: cturt@hardenedbsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 20:52:15 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207626 Bug ID: 207626 Summary: Memory leak in ctl.c Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: cturt@hardenedbsd.org There is a memory leak in `sys/cam/ctl/ctl.c`. `ctl_copyin_alloc` performs and returns an allocation with `malloc`: static void * ctl_copyin_alloc(void *user_addr, int len, char *error_str, size_t error_str_len) { void *kptr; kptr =3D malloc(len, M_CTL, M_WAITOK | M_ZERO); if (copyin(user_addr, kptr, len) !=3D 0) { snprintf(error_str, error_str_len, "Error copying %d bytes " "from user address %p to kernel address %p", len, user_addr, kptr); free(kptr, M_CTL); return (NULL); } return (kptr); } `ctl_copyin_args` calls this function, but doesn't free the returned alloca= tion on the condition that the string is not terminated, before going to `bailou= t`: static struct ctl_be_arg * ctl_copyin_args(int num_args, struct ctl_be_arg *uargs, char *error_str, size_t error_str_len) { ... uint8_t *tmpptr; ... if (args[i].flags & CTL_BEARG_RD) { tmpptr =3D ctl_copyin_alloc(args[i].value, args[i].vallen, error_str, error_str_len); if (tmpptr =3D=3D NULL) goto bailout; if ((args[i].flags & CTL_BEARG_ASCII) && (tmpptr[args[i].vallen - 1] !=3D '\0')) { snprintf(error_str, error_str_len, "Argumen= t " "%d value is not NUL-terminated", i); goto bailout; } args[i].kvalue =3D tmpptr; } else { args[i].kvalue =3D malloc(args[i].vallen, M_CTL, M_WAITOK | M_ZERO); } } return (args); bailout: ctl_free_args(num_args, args); return (NULL); } Should be: snprintf(error_str, error_str_len, "Argumen= t " "%d value is not NUL-terminated", i); free(tmpptr); goto bailout; --=20 You are receiving this mail because: You are the assignee for the bug.=