From owner-freebsd-bugs@FreeBSD.ORG  Tue Jun 11 18:50:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 4F1145FA
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 11 Jun 2013 18:50:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 411BD15E8
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 11 Jun 2013 18:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r5BIo1jm084519
 for <freebsd-bugs@freefall.freebsd.org>; Tue, 11 Jun 2013 18:50:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r5BIo0gE084517;
 Tue, 11 Jun 2013 18:50:01 GMT (envelope-from gnats)
Date: Tue, 11 Jun 2013 18:50:01 GMT
Message-Id: <201306111850.r5BIo0gE084517@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: bin/113239: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jun 2013 18:50:01 -0000

The following reply was made to PR bin/113239; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/113239: commit references a PR
Date: Tue, 11 Jun 2013 18:43:54 +0000 (UTC)

 Author: ghelmer
 Date: Tue Jun 11 18:43:27 2013
 New Revision: 251625
 URL: http://svnweb.freebsd.org/changeset/base/251625
 
 Log:
   Prevent races running the queue by serializing access to the
   queue directory.
   
   PR:		bin/113239
 
 Modified:
   head/libexec/atrun/atrun.c
 
 Modified: head/libexec/atrun/atrun.c
 ==============================================================================
 --- head/libexec/atrun/atrun.c	Tue Jun 11 18:43:25 2013	(r251624)
 +++ head/libexec/atrun/atrun.c	Tue Jun 11 18:43:27 2013	(r251625)
 @@ -31,6 +31,7 @@ static const char rcsid[] =
  /* System Headers */
  
  #include <sys/fcntl.h>
 +#include <sys/file.h>
  #include <sys/types.h>
  #include <sys/stat.h>
  #ifdef __FreeBSD__
 @@ -521,6 +522,9 @@ main(int argc, char *argv[])
      if ((spool = opendir(".")) == NULL)
  	perr("cannot read %s", ATJOB_DIR);
  
 +    if (flock(dirfd(spool), LOCK_EX) == -1)
 +	perr("cannot lock %s", ATJOB_DIR);
 +
      now = time(NULL);
      run_batch = 0;
      batch_uid = (uid_t) -1;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"