From owner-svn-src-all@FreeBSD.ORG Thu Mar 17 13:37:44 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1E971065676; Thu, 17 Mar 2011 13:37:44 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail04.syd.optusnet.com.au (mail04.syd.optusnet.com.au [211.29.132.185]) by mx1.freebsd.org (Postfix) with ESMTP id 73F8A8FC18; Thu, 17 Mar 2011 13:37:44 +0000 (UTC) Received: from c122-107-125-80.carlnfd1.nsw.optusnet.com.au (c122-107-125-80.carlnfd1.nsw.optusnet.com.au [122.107.125.80]) by mail04.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p2HDbf91011746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Mar 2011 00:37:42 +1100 Date: Fri, 18 Mar 2011 00:37:41 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Konstantin Belousov In-Reply-To: <201103171123.p2HBNCGh025820@svn.freebsd.org> Message-ID: <20110318001402.H1537@besplex.bde.org> References: <201103171123.p2HBNCGh025820@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r219712 - head/sys/ufs/ufs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2011 13:37:45 -0000 On Thu, 17 Mar 2011, Konstantin Belousov wrote: > Log: > Remove the #if defined(FFS) || defined(IFS) braces around the calls to > ffs_snapgone(). ufs.ko module is not build with FFS define, causing > snapshot inode number slots in superblock never be freed, as well as a > reference on the snapshot vnode. > > IFS was removed several years ago, and UFS/FFS separation was not > maintained for real. > > Reported, analyzed and tested by: Yamagi Burmeister > MFC after: 3 days This seems to leave FFS correctly unused. Most options for file systems are put in opt_dontuse.h to inhibit bugs like this (but I never figured out a way to generate a compile time error if an option in there is used). The FFS option is special. It should not be special. It was moved from opt_dontuse.h to opt_ffs_broken_fixme.h in 2001 to avoid a collateral bug: the FFS/UFS split doesn't work, but was used by ext2fs, and it is a layering violation for UFS to call ffs_snapgone() in FFS, and this broke the configuration with EXT2FS (and UFS) but not FFS; this was hacked around by the ifdefs. ext2fs was decoupled from UFS in 2002, so the ifdefs became unnecessary, but they remained to break the module. opt_ffs_broken_fixme.h also became unnecessary in 2002, but remains to generate history lessons :-). The ifdef on IFS was even more bogus, since IFS doesn't exist and has no vestiges in conf/*. Bruce