From owner-svn-src-head@freebsd.org Fri Aug 7 16:22:49 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E1B13BED08; Fri, 7 Aug 2020 16:22:49 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BNVyK1Flnz4dGQ; Fri, 7 Aug 2020 16:22:48 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ej1-f46.google.com with SMTP id bo3so2656133ejb.11; Fri, 07 Aug 2020 09:22:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EvAwgak/2IWgwQvQKk8yxp//pobirLHb1YFzINofxJo=; b=M7qULUfyOjKcGIRIMNDA7UzSneIBs7DW5aW/TKJUVMj/0eTLZPuRCXITv6J7LUCVHz oHOnhSVzOwX//PC6bysdIKKqj9iDY8zBvy2X71rCOFRf/1GfT8jAc436YsxgBHud4STr 1Y/UsIFdJRfhN7oeq2r5bPuWgxPYUXCs0gimM3BQxYgdhM2y9O0eHNSvv7miBPsLJfMW sHLs+fT1oIsAZ+lrF6gWTpuO/naanzHjH8t07NDGaHrALXNhH2UyMYyzfQW4fEINQwhR 9AIWehh//xPce4Wj/M7ByuzZs8rB9Quc8N9kXdfJefCJFYuqsblWfG5unzuXm1zQUa4m 5s6g== X-Gm-Message-State: AOAM530NYva/BvDGe2e35ZUNh1EwzgHg5IhFcfUsHNWtXzQnehk6pSdE mXb3A67wQmYGmkOQ7PemXSv07bNDzFc= X-Google-Smtp-Source: ABdhPJyFKo47JWNZO7QzNLPM711s1gtjF0PdcaBXAqHHgMTNcZc6BRoy15/IEYBXePUgTgNufofg8A== X-Received: by 2002:a17:906:3b97:: with SMTP id u23mr10447514ejf.31.1596817367020; Fri, 07 Aug 2020 09:22:47 -0700 (PDT) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com. [209.85.128.42]) by smtp.gmail.com with ESMTPSA id sb3sm6304613ejb.113.2020.08.07.09.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 09:22:46 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id k20so2384885wmi.5; Fri, 07 Aug 2020 09:22:46 -0700 (PDT) X-Received: by 2002:a1c:9a02:: with SMTP id c2mr14730855wme.16.1596817366427; Fri, 07 Aug 2020 09:22:46 -0700 (PDT) MIME-Version: 1.0 References: <202008071604.077G41dj025962@repo.freebsd.org> In-Reply-To: From: Alexander Richardson Date: Fri, 7 Aug 2020 17:22:35 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r364023 - head/usr.bin/grep To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BNVyK1Flnz4dGQ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 16:22:49 -0000 On Fri, 7 Aug 2020 at 17:06, Kyle Evans wrote: > > On Fri, Aug 7, 2020 at 11:04 AM Alex Richardson wrote: > > > > Author: arichardson > > Date: Fri Aug 7 16:04:01 2020 > > New Revision: 364023 > > URL: https://svnweb.freebsd.org/changeset/base/364023 > > > > Log: > > Always install usr.bin/grep as grep when bootstrapping > > > > We have to bootstrap grep when cross-building from macOS/Linux. > > > > What's going on here that it isn't bootstrapping gnugrep over in > gnu/usr.bin/grep as grep? My gut instinct is that we're missing > something else and this isn't quite the right place to have addressed > this. > The logic in Makefile.inc1 builds usr.bin/grep as the bootstrap grep when BOOTSTRAP_ALL_TOOLS is set (e.g. when building on macOS/Linux). If you think this should be gnu/usr.bin/grep instead I can revert this change and update Makefile.inc1. We have been using usr.bin/grep for bootstrap in CheriBSD for a long time now and it works fine so I'm not sure whether we need to use GNU grep for bootstrapping? Alex