From owner-freebsd-current@FreeBSD.ORG  Mon Feb 14 15:37:59 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E385106566C;
	Mon, 14 Feb 2011 15:37:59 +0000 (UTC)
	(envelope-from imb@protected-networks.net)
Received: from sarah.protected-networks.net (sarah.protected-networks.net
	[IPv6:2001:470:1f07:4e1::1])
	by mx1.freebsd.org (Postfix) with ESMTP id A37468FC08;
	Mon, 14 Feb 2011 15:37:58 +0000 (UTC)
Received: from toshi.auburn.protected-networks.net
	(toshi.auburn.protected-networks.net [IPv6:2001:470:1f07:4e1::4])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(Client CN "Iain Butler",
	Issuer "RSA Class 2 Personal CA" (verified OK))
	(Authenticated sender: imb@protected-networks.net)
	by sarah.protected-networks.net (Postfix) with ESMTPSA id 915E96133;
	Mon, 14 Feb 2011 10:37:57 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
	d=protected-networks.net; s=200705; t=1297697877;
	bh=nyk9LNrcY0/DXoUj3+DiatykZ53l7azAmgMsXa+5g6Q=;
	h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References:
	In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=A3d7aM9iA0Vvrvq64WCZtx22erIEmJF4hXN6ftPoZwH+BdbIPx3surflH/lHe2yWW
	HgN2alxeL2dNRHzm+1qbtIPgv/khRfS2zFxcXf3/yPJecn9uQLI0vbt5woWJbrQ
DomainKey-Signature: a=rsa-sha1; s=200509; d=protected-networks.net; c=nofws;
	q=dns; 
	h=message-id:date:from:user-agent:mime-version:to:cc:subject:
	references:in-reply-to:x-enigmail-version:openpgp:content-type:content-transfer-encoding;
	b=bN0TP/kAjB1TBLHdDVUBPMBXEYApUx9hEpZlUWN0AcDAMYoKAVUq83kpoZX079xiu
	FD/MmRik6k5y6DrEDl6RGFldkKMHf+TNQ3O655+85R2FbWuts1jLYxx805q8sN5
Message-ID: <4D594C54.5000801@protected-networks.net>
Date: Mon, 14 Feb 2011 10:37:56 -0500
From: Michael Butler <imb@protected-networks.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.2.13) Gecko/20110116 Thunderbird/3.1.7
MIME-Version: 1.0
To: Matthew Fleming <mdf356@gmail.com>
References: <AANLkTi=C31iGJMonj7E3DGLWhx0cSKQR=b7ZHTv9CdmA@mail.gmail.com>	<201102140924.36531.jhb@freebsd.org>
	<AANLkTimKJnyFQgTgtLTOFvmcY4fbK5gdT6mwt9zB=+RY@mail.gmail.com>
In-Reply-To: <AANLkTimKJnyFQgTgtLTOFvmcY4fbK5gdT6mwt9zB=+RY@mail.gmail.com>
X-Enigmail-Version: 1.1.2
OpenPGP: id=0442D492
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
Subject: Re: acpi_resource bug?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2011 15:37:59 -0000

On 02/14/11 10:29, Matthew Fleming wrote:
>>> 1) should the length of the bcopy() be changed to either respect
>>> res->Length or the actual length of the ACPI_RESOURCE_DATA for the
>>> type?
>>
>> It should just use res->Length:
> 
> Is there a guarantee that res->Length is <= sizeof(ACPI_RESOURCE) ?

I don't know if it's related or a different bug ..

If I run 'acpidump -t', I get a core-dump and ..

 [ .. snip .. ]

/*
  MCFG: Length=60, Revision=1, Checksum=74,
        OEMID=INTEL, OEM Table ID=CALISTGA, OEM Revision=0x6040000,
        Creator ID=LOHR, Creator Revision=0x5a

        Base Address=0x00000000e0000000
        Segment Group=0x0000
        Start Bus=0
        End Bus=255
 */
/*
  TCPA: Length=50, Revision=1, Checksum=153,
        OEMID=PTLTD, OEM Table ID=CALISTGA, OEM Revision=0x6040000,
        Creator ID= PTL, Creator Revision=0x1
        Class 0 Base Address 0x0 Length 65536

        -268370093 0xc3e200f053ff00f053ff00f054ff00f0de9100f0 [<unknown
0xf000ff53>]