From owner-freebsd-current  Wed Jan 27 17:06:59 1999
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id RAA11988
          for freebsd-current-outgoing; Wed, 27 Jan 1999 17:06:59 -0800 (PST)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA11982
          for <current@FreeBSD.ORG>; Wed, 27 Jan 1999 17:06:57 -0800 (PST)
          (envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.9.2/8.9.1) id RAA81012;
	Wed, 27 Jan 1999 17:06:56 -0800 (PST)
	(envelope-from dillon)
Date: Wed, 27 Jan 1999 17:06:56 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <199901280106.RAA81012@apollo.backplane.com>
To: current@FreeBSD.ORG
Subject: bug in i386/eisa/ahb.c
References:  <199901272244.OAA64912@apollo.backplane.com>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

static __inline void
ahbqueuembox(struct ahb_softc *ahb, u_int32_t mboxval, u_int attn_code)
{
        u_int loopmax = 300;
        while (--loopmax) {
                u_int status;
 
                status = ahb_inb(ahb, HOSTSTAT);
                if ((status & HOSTSTAT_MBOX_EMPTY|HOSTSTAT_BUSY) 
		   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

                   != HOSTSTAT_MBOX_EMPTY) 
                        break;
                DELAY(20);
        }
        if (loopmax == 0) 
                panic("ahb%ld: adapter not taking commands\n", ahb->unit);
  
        ahb_outl(ahb, MBOXOUT0, mboxval);
        ahb_outb(ahb, ATTN, attn_code);
}

    & has higher precedence, so this is equivalently:

	if (((status & HOSTSTAT_MBOX_EMPTY) | HOSTSTAT_BUSY) ...

    Rather then:

	if ((status & (HOSTSTAT_MBOX_EMPTYHOSTSTAT_BUSY)) ...

    Fixed.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message