From owner-svn-src-head@freebsd.org Wed Nov 21 21:36:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FCE3114735A; Wed, 21 Nov 2018 21:36:34 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6103F77DC2; Wed, 21 Nov 2018 21:36:33 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by mail-lj1-x236.google.com with SMTP id e5-v6so6143019lja.4; Wed, 21 Nov 2018 13:36:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PUlzcvY2b/Yl0PhH2juxGSjJII7zuqAuGxN+rtA98Ak=; b=AjfgXIx7dalOHWpeX7iCOr6PYM+S+mtL4HeaxEuIG/rv4mLptAeOX+VvBGGgOwlGM6 raAwQmen1apb/QFP0CuLH7ew/z2GXkG4xmomPDGlLarvAn2KuxcHC5aMSmjKTq+mKYNf nsdCox6ANuwReHbGpa3/kyGoGtOqTQavmYN739arHx/M4tP+mVwfpd6gGCTsqq0frnZF 7vgVCGp48tVNAYXLK3rcTQj8IpQmpwPeL60HvIG0LgjflWArM/Amv8V3HYMpd3fGbVtl S2RPQoE+5V19BWJvKrf1qnR07p4RgX0hXWSRl5SIoG1llO2Ej7Y3Admzo8cHbnGmGCNM NLAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=PUlzcvY2b/Yl0PhH2juxGSjJII7zuqAuGxN+rtA98Ak=; b=WHQ1uk3ldCgIPWRsD/SgVc99iesH9vgqd08XewUUCv6I8zPHqezbYWobDs4169mOeK JQ+FrwiAbxM9oiWyXn2I0jBF/WeHFcxd9lyMvrtuToOLjGZdUfuMb4TvoHsZPJdTPPEa UYfhHIyDmrwnUf0Klw3Zsn8McFub0G3azcQ9S6knQeU9ojmIkOQ3bvPO9YQE/FmhRr+j 3SES+dt7lx/xcGxKaWT/UeqOGqMsZwvx4P9/C40UcntV54wtULL+UqunBp/3c5Mt8Tv0 8u5Z0n9OWJtOnTqywoF17LkHHYc67M2uarQI0Nq13pPaWxYhefVCLc+0vIji6BYhe/FH rn7A== X-Gm-Message-State: AA+aEWby11g/44GSFT/4vJKBK73ik7IEFS/hdbgJ/1nEOQcKOWsv8CEi VIOBO4Hrrpype/9R2Kxz+dMPvcyF X-Google-Smtp-Source: AFSGD/Wt0rHU8E8jzbYDobDjvth9uimmbapGpakNwmuExtgy9kyp6rQq7m2EMDsMicZfgB/ijAVeYQ== X-Received: by 2002:a2e:83d7:: with SMTP id s23-v6mr5613247ljh.139.1542836191526; Wed, 21 Nov 2018 13:36:31 -0800 (PST) Received: from x-wing (87-206-170-77.dynamic.chello.pl. [87.206.170.77]) by smtp.gmail.com with ESMTPSA id h21sm6939194lfk.41.2018.11.21.13.36.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Nov 2018 13:36:30 -0800 (PST) Sender: Mariusz Zaborski Date: Wed, 21 Nov 2018 22:36:41 +0100 From: Mariusz Zaborski To: rgrimes@freebsd.org Cc: Kyle Evans , 0mp@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Subject: Re: svn commit: r340722 - head/lib/libbe Message-ID: <20181121213641.GA54339@x-wing> References: <201811211654.wALGsAPT072769@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <201811211654.wALGsAPT072769@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 6103F77DC2 X-Spamd-Result: default: False [-5.44 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[oshogbo@freebsd.org,oshogbovx@gmail.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.65)[ipnet: 2a00:1450::/32(-1.58), asn: 15169(-1.57), country: US(-0.09)]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[oshogbo@freebsd.org,oshogbovx@gmail.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[6.3.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 21:36:34 -0000 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 21, 2018 at 08:54:10AM -0800, Rodney W. Grimes wrote: > > On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes > > wrote: > > > > > > > Author: 0mp (ports committer) > > > > Date: Wed Nov 21 11:22:44 2018 > > > > New Revision: 340722 > > > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > > > > > Log: > > > > libbe(3): Put each error value in separate line. > > > > > > > > As requested by a TODO in the source code. > > > > > > > > Reviewed by: bcr > > > > Approved by: krion (mentor, implicit), mat (mentor, implic= it) > > > > Differential Revision: https://reviews.freebsd.org/D18063 > > > > > > Who with a src bit approved the commit to src? > > > > >=20 > > I do want to clarify- bcr approved it in the review (explicitly with > > "... hereby approved!") -- are you mainly pointing out that he failed > > to annotate this properly in the commit, or is doc bit approval for a > > commit to a manpage in src insufficient? >=20 > That is defanitly a bit of a grey area, from reading and re-reading > the commit bit page it is clear that a doc committer can commit > to src documentation, it is not clear if they can approve a commit > by someone else to the src tree, it does say > ""Approved by" from a non-mentored committer > with the appropriate bit" >=20 > It probably would be fine to have said Approved by: bcr. >=20 > I still question what a out of scope commit that is > approved by: (mentor, implicit). I am not even sure > what that means in this context. Have his mentors > said he can commit anything anyplace without them > seeing it? If so then release the mentor/mentee bit > would be more appropriate? >=20 > >=20 > > As an aside, happy to approve any changes to these manpages as the > > current bectl/libbe maintainer for anyone that wants to improve them. > > =3D) >=20 > That defanitly would of been a cleaner path. C'mon guys. Mateusz is doing a great job with documentation - THANK YOU! I would be more outraged that we still didn't appreciate him. Thanks, --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD committer | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAlv1z+QACgkQ38KEGuLG xWQu6RAAlN0swKr+z/eS9xag31ZYazLY/jOtG0Ucdea5ZQ7LsAbd2csTZXf0daJh zaMl8+hlo5jHiDYI9+2VvOuZ0tjmS8QopkJ/BTm+SWi5/ELDVnOsfGkElnwsA6I8 L0+emkpVaCfZVHlYxuhWbb1FvvVztDk31OdmN0gqArUZ5znswJqIOdOEEph6qPnv 2E9RT/mkMKJKDi55b0lwkZ8RbpFmXo5bFUXtq2EwoWaZllXvtlYoxtxHlDHITauh 5E6yhnCk4DhEYfMGCKuF3cHqc1Z8qzPT7NxRaJoXbncVrgKWdfb/ubL2nigkLKyb CLRxqF7VaCnRaAn46J2EsKsoZWjPIijcImIckz/r7s0xy9Jtc52is5TTr5MzGnwR xB9b+iwp6nabjzpiYtHgScME5WDmLH4av0jOTnARic0Mi7eFQ66KYcScgWeSnlh0 4TkGN4yN2Fl8cenMzVaa82sGci5AAxEnffIc6SWTP3U+Nw8W492TNv+txvWkjsL4 L+mUqzIjxYjLtkucR/r3/3o1j5RYcmlT3cAM+Qu75nLviMxcwEg4yQCP8fhsNjji yuMHkx2oDow0yhVDPpeLCazEXzta8LgPer3pqZcXg38LWuaYvyh2OQh8AO5YwQCF gnF9qzG76BgKOmFpj6w0HSk/GdE5Kp2B1BJNXDfwS1NEDP9mDxk= =4BEr -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--