From owner-svn-src-all@FreeBSD.ORG Wed Nov 12 22:07:25 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 041D2C06; Wed, 12 Nov 2014 22:07:25 +0000 (UTC) Received: from mail-ie0-x22e.google.com (mail-ie0-x22e.google.com [IPv6:2607:f8b0:4001:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDC33F15; Wed, 12 Nov 2014 22:07:24 +0000 (UTC) Received: by mail-ie0-f174.google.com with SMTP id x19so14560963ier.33 for ; Wed, 12 Nov 2014 14:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=eQvTZq0I6WLzEu+czTFaeydD/7cCAgLoWw7MEuebmPU=; b=tp1v23N7wf85YmdQNAPq8xsEUUx4TTLZP6mX8jiW+yhz5glg5LFkJa7+DhrASBmykM 4gk/XrwpDbsBF5GdwqpIPdurzaQynhjXLMyarr26+gILNxQvzFEe3p83pTV89Pv4Bpd1 8V8uuiUTcIgqEaR4pjdQxGPWkgY6XZhdhaTXno5IRfruZjxkwsy5r5PYEKxHZB54QhLt JyKdBc20z9alcTkfsFGh8deeHetFSb5SnyKh5NbKUWkHa/Xf/J3vIfvouy3d8go4i5/6 7p22eflPJT4Oo2hD2MCLRXo2peawsjhKSOGWe4hgoZADFiRq4HVbzAFAdHrLXrfwYB7X 0zog== MIME-Version: 1.0 X-Received: by 10.107.29.197 with SMTP id d188mr21573084iod.57.1415830044031; Wed, 12 Nov 2014 14:07:24 -0800 (PST) Received: by 10.50.235.49 with HTTP; Wed, 12 Nov 2014 14:07:23 -0800 (PST) In-Reply-To: References: <201411061719.sA6HJgFu062138@svn.freebsd.org> Date: Wed, 12 Nov 2014 14:07:23 -0800 Message-ID: Subject: Re: svn commit: r274186 - head/share/mk From: NGie Cooper To: Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "bdrewery@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 22:07:25 -0000 On Thu, Nov 6, 2014 at 9:21 AM, Garrett Cooper wrot= e: > On Nov 6, 2014, at 9:19, Warner Losh wrote: > >> Author: imp >> Date: Thu Nov 6 17:19:41 2014 >> New Revision: 274186 >> URL: https://svnweb.freebsd.org/changeset/base/274186 >> >> Log: >> Ignore errors from rm -rf to support high -j builds. This is, at best, >> a kludge. However, it also effectively works around the issues for >> high -j builds on systems that do not have the rm fixes. >> >> A better fix would be to rmdir here, and fix the places where we're >> sloppy and not list all the files we create in CLEANFILES, should >> anybody have the time to chase them all to ground. > > I=E2=80=99ll say that bsd.progs.mk is a huge problem here because CLEANFI= LES is handled times. > > Dealing with bsd.progs.mk and its recursive nature is quite entertaining.= .. Another question related to this commit... Why aren't return codes ignored for rm -f ${CLEANFILES} ? bdrewery@ ran into an issue at $work where the build failed after r268376 because he ran into ESTALE with rm: 13:51 <@bdrewery> rm: fts_open: Stale NFS file handle This commit will allow the build to continue when dealing with ESTALE on directories, but it won't fix the case where we hit ESTALE with CLEANFILES. Thanks!