Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 02 Apr 2018 10:41:28 +0200
From:      Harry Schmalzbauer <freebsd@omnilan.de>
To:        Mark Johnston <markj@freebsd.org>
Cc:        svn-src-head@freebsd.org, Sean Bruno <sbruno@freebsd.org>, src-committers@freebsd.org, glebius@freebsd.org, svn-src-all@freebsd.org
Subject:   Re: svn commit: r324508 - head/sys/kern
Message-ID:  <5AC1ECB8.6050709@omnilan.de>
In-Reply-To: <20180401164726.GA953@raichu>
References:  <201710102221.v9AML554015782@repo.freebsd.org> <5ABF55FC.6030102@omnilan.de> <20180401164726.GA953@raichu>

next in thread | previous in thread | raw e-mail | index | archive | help
Bezüglich Mark Johnston's Nachricht vom 01.04.2018 18:47 (localtime):
> On Sat, Mar 31, 2018 at 11:33:48AM +0200, Harry Schmalzbauer wrote:
>>  Bezüglich Sean Bruno's Nachricht vom 11.10.2017 00:21 (localtime):
>>> Author: sbruno
>>> Date: Tue Oct 10 22:21:05 2017
>>> New Revision: 324508
>>> URL: https://svnweb.freebsd.org/changeset/base/324508
>>>
>>> Log:
>>>   match sendfile() error handling to send().
>>>   
>>>   Sendfile() should match the error checking order of send() which
>>>   is currently:
>>>   
>>>   SBS_CANTSENDMORE
>>>   so_error
>>>   SS_ISCONNECTED
>>>   
>>>   Submitted by:	Jason Eggleston <jason@eggnet.com>
>>>   Reviewed by:	glebius
>>>   MFC after:	2 weeks
>>>   Sponsored by:	Limelight Networks
>>>   Differential Revision:	https://reviews.freebsd.org/D12633
>>>
>>> Modified:
>>>   head/sys/kern/kern_sendfile.c
>>>
>>
>> I'm still applying this one locally to stable/11.
>> Is it going to be MFCd before 11.2?
>>
>> There are a view more candidates:
>> https://svnweb.freebsd.org/base?view=revision&revision=324601 along with
>> r324448
>> https://svnweb.freebsd.org/base?view=revision&revision=327596
>> https://svnweb.freebsd.org/base?view=revision&revision=328977
>> These were flagged for MFC with expired defer time.
>> And tomorrow this one was supposed to be MFCd also:
>> https://svnweb.freebsd.org/base?view=revision&revision=331130
> 
> I think r324446 and r324448 need to be MFCed before most of these can go
> in. I MFCed the other commits (r317567, r324508) that you asked about in
> other threads.

Thanks for MFCing the unrelated other two (r317567, r324508) from cem@!

Hope someone finds time to sort out the dependiencies of r324446,
r324448 and this r324508 along with r324601, r327596, r328977.

Currently I don't have a sendfile() test case, but for some reason I
stumbled across this MFCflagged commit some time ago and I guess 11.2
shouldn't ship without.

Thanks,

-harry




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5AC1ECB8.6050709>