From owner-cvs-src Thu Feb 20 15:36:54 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 45D4F37B401; Thu, 20 Feb 2003 15:36:52 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC83143FB1; Thu, 20 Feb 2003 15:36:51 -0800 (PST) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 84D6CAE2BE; Thu, 20 Feb 2003 15:36:51 -0800 (PST) Date: Fri, 21 Feb 2003 00:36:51 +0100 From: Maxime Henrion To: Nate Lawson Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20030220233651.GQ60813@elvis.mu.org> References: <20030220212005.GP60813@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Nate Lawson wrote: > On Thu, 20 Feb 2003, Maxime Henrion wrote: > > Nate Lawson wrote: > > > On Wed, 19 Feb 2003, Maxime Henrion wrote: > > > > Modified files: > > > > sys/pci if_xl.c > > > > Log: > > > > Fix panic on sparc64 introduced in my last commit. I really > > > > wish the busdma APIs were more consistent accross architectures. > > > > > > > > We should probably move all the other DMA map creations in > > > > xl_attach() where we can really handle them failing, since > > > > xl_init() is void and shouldn't fail. > > > > > > Please see my patches for adding/fixing error handling for dmamap_load > > > (posted to -current). I am going to remove the unnecessary intr alloc > > > move but otherwise they should be fine. > > > > Where are those patches ? I only found > > http://www.root.org/~nate/freebsd/xl.diff, which is not related to > > busdma at all. > > You're right. The fixes were for other drivers. Ah, ok. I'll take a look at these fixes as soon as possible (hopefully tomorrow). Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message