From owner-svn-src-head@freebsd.org Fri Apr 14 20:07:05 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 130D2D3EB54; Fri, 14 Apr 2017 20:07:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x229.google.com (mail-pg0-x229.google.com [IPv6:2607:f8b0:400e:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CE38F3D6; Fri, 14 Apr 2017 20:07:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x229.google.com with SMTP id 21so47247360pgg.1; Fri, 14 Apr 2017 13:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=yiuIOuGgHvcF9QEPTc6Ud+VoZlP4Bs8fN9mWL+y0jv8=; b=RCL9DK2Vpdh1ZuYau4h3Jcr5IJBRhxY3EcYtRap4W4Rg/PtAPLAOwmE4rierNd0mAc VdAHxWDBIO45hK9IpEC2FzCqhlYgD6DRwnFCHPM9iLnZpeAXYca+UVBUslmS/8V74oXe g8GoSu0cgacaiC7TYtaPOQBx1cglDYuoOQ+WFt+LlfOR9dzebin1zDXn00f4pE55Klli o4eQAPikP8kFk7cDk4CZAiCcJtghSEMRL9EXyau4U/K8rW/IztRaJ0Pes0HsBv32Ti5k YlyvIOzYYCkOTBsyDU41erWv/lUg+ggE00GfrZ9gqKZL5aHxo9ztMS+BQD2JQTGLoe/0 ijIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=yiuIOuGgHvcF9QEPTc6Ud+VoZlP4Bs8fN9mWL+y0jv8=; b=kGSbjHvUAD3S7+ffxTlOmDcq6ZUoRr0VYSU47QdL0svfZPSdY9GjaitKn8yAexG04J jKpqux+kGIbIdAC5moRQwEcgRqCU+LL56BMlLoWool7DSqz9O0tr4ihfDEuK1G51nLjv HCg2jXiCQNPwmfJYcepa8IedXXaFhv7wk8Jbt5p0MwcAPQeoYhCIxSmJ3xla98Cq3dD4 OiPISOHvvuSst6APi8sW3yH7LfujOs/OiufyG01EYV1tDJ+MjfJB+dnGlKpWj0+O7kg1 AkcNBSDBKD8hnufBIndCYHVnMuTAm4jWRXH56/uqbWBMxt3apKIGnYXOSgZqhePioUx0 AyeQ== X-Gm-Message-State: AN3rC/5FRxim5S/OWIZORC+s3tFRo/t0Vhf6EiuR9bUfX4yNZT2IVLM3 00O29YRUT8UObS/cBBg= X-Received: by 10.99.61.130 with SMTP id k124mr8572887pga.68.1492200424177; Fri, 14 Apr 2017 13:07:04 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id a77sm4732452pfj.1.2017.04.14.13.07.02 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Apr 2017 13:07:03 -0700 (PDT) Subject: Re: svn commit: r316938 - head/sbin/savecore Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A38279AE-4145-470F-902C-5F719E69AB0A"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <7DCBB59B-388F-463D-8FFF-06390E5B5165@gmail.com> Date: Fri, 14 Apr 2017 13:07:02 -0700 Cc: Ngie Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <25EDEFF2-4993-4C95-B005-8670DF513B72@gmail.com> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <499FA6FF-E691-4941-B96C-3806072D14AA@gmail.com> <7DCBB59B-388F-463D-8FFF-06390E5B5165@gmail.com> To: Alan Somers X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 20:07:05 -0000 --Apple-Mail=_A38279AE-4145-470F-902C-5F719E69AB0A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 14, 2017, at 13:04, Ngie Cooper (yaneurabeya) = wrote: >=20 >=20 >> On Apr 14, 2017, at 13:02, Alan Somers wrote: >=20 > ... >=20 >> Right: check_size() needs to know the on-disk size of the core dump. >> But it doesn't have any way to know the on-disk size until after it's >> written everything to disk. That's why I simply disabled the check = at >> $WORK. Another possibility would be for savecore to ignore the >> up-front check, but handle ENOSPC by deleting the fragmentary vmcore >> file. I never tried to implement that. >=20 > Let me dig through the gzip format a bit. There should be a reasonably = good upper bound approximation that we can use for compressed mini = dumps. Also: deleting truncated dumps sounds great to me: their value when = truncated is pretty low from what I remember. -Ngie --Apple-Mail=_A38279AE-4145-470F-902C-5F719E69AB0A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8SvmAAoJEPWDqSZpMIYVMwUP/is9SwaUluIZqVpzW7koduPG DNu4ejTX6ZgR0YZ8//+PiTNI4S7WfKUiCZdeIaScDDQWtftLRWUzKyhvSnyfPwLg /WPc5+NDjpih7rwmMvXm+uBRV6VhQosY83cl81DSBD7q3bhC8g00WLDH8325xaFe OPUWG2XCzyo2jzTXeABHxiX1Px/+L/+17UzorBxhnXrNAxlzBkjKwrWucmu2oef5 YgfPM/M3CkqCNPsbnVCiTQ2VQR3EsOGd6IAfJ7sQkcWiRE5o9hmpIpT62s05sftr rGjOiEXlgfMmRpxRE2r7StJ5ltPorwMI61Svc8cNTLbsOxJPwd5D4l8qvpSwVvWf HicHbLVkXegMt3yOfkD7d6aQ+PzUW68kz4zHnr8JaaTxhqEUc8fRpfeiMtyZTl2T twoD7nShU0r4whbvRfTO5nozzhVHlHwSuuvsNbEeLOyEx0hi2sv2IuN6HoV2WdHP wmSDua3qlFZYPfiFj64mXDvr8ncKkjBNQ4ycuQQVObqQrc8IfV7/P0NSwDVLaxzm 0nd+qDE+Tna18ThBwZXFOHrR0Cl91TYPL4GkHF5pdrL3VJeVWL9Xgcae79DqRWK5 YXsTk0v4dswr4gLCs3buI2Hl+wfqCGJHT5UH8fAOK2OCuHwx/ZhWvhH6K9eFjL5J 9PsHnv/15xiDkLzUhrtV =9WWL -----END PGP SIGNATURE----- --Apple-Mail=_A38279AE-4145-470F-902C-5F719E69AB0A--