From owner-freebsd-net@FreeBSD.ORG  Tue Jul 28 16:20:00 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0933D1065674
	for <freebsd-net@freebsd.org>; Tue, 28 Jul 2009 16:20:00 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outF.internet-mail-service.net (outf.internet-mail-service.net
	[216.240.47.229])
	by mx1.freebsd.org (Postfix) with ESMTP id E1A908FC08
	for <freebsd-net@freebsd.org>; Tue, 28 Jul 2009 16:19:59 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id E30428ED2B;
	Tue, 28 Jul 2009 09:19:59 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id 54B042D6017;
	Tue, 28 Jul 2009 09:19:59 -0700 (PDT)
Message-ID: <4A6F2533.4050007@elischer.org>
Date: Tue, 28 Jul 2009 09:20:03 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
MIME-Version: 1.0
To: Oleg Sharoyko <os@sfedu.ru>
References: <1248704237.96833.127.camel@brain.cc.rsu.ru>	
	<4A6DE356.6040006@elischer.org> <4A6DEE30.6000108@sfedu.ru>	
	<4A6DFFA1.1010709@elischer.org> <4A6E0121.2020004@sfedu.ru>	
	<4A6E05EC.8050401@elischer.org> <4A6E0A8B.5000103@sfedu.ru>	
	<4A6E2666.2040906@elischer.org> <4A6E3743.7050708@elischer.org>
	<1248788292.71222.10.camel@brain.cc.rsu.ru>
	<4A6F1D76.7040806@elischer.org> <4A6F24BB.7050907@sfedu.ru>
In-Reply-To: <4A6F24BB.7050907@sfedu.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
Subject: Re: Wrong outgoing interface with multiple routing tables
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2009 16:20:00 -0000

Oleg Sharoyko wrote:
> Julian Elischer wrote:
> 
>> I'll get that checked in!
> 
> Please, also take a look at
> 
> _syncache_add() in tcp_syncache.c
> 
> There is some code which looks strange, at least at first sight. Won't 
> bcopy() overwrite assigned value of sc->sc_inc.inc_fibnum ?
> 
>         /* XXX-BZ this fib assignment is just useless. */
>         sc->sc_inc.inc_fibnum = inp->inp_inc.inc_fibnum;
>         bcopy(inc, &sc->sc_inc, sizeof(struct in_conninfo));

the bcopy just writes teh same vlue in again

I've removed this in the patch.

> 
> -- 
> Oleg