Date: Tue, 28 Jul 2009 09:20:03 -0700 From: Julian Elischer <julian@elischer.org> To: Oleg Sharoyko <os@sfedu.ru> Cc: freebsd-net@freebsd.org Subject: Re: Wrong outgoing interface with multiple routing tables Message-ID: <4A6F2533.4050007@elischer.org> In-Reply-To: <4A6F24BB.7050907@sfedu.ru> References: <1248704237.96833.127.camel@brain.cc.rsu.ru> <4A6DE356.6040006@elischer.org> <4A6DEE30.6000108@sfedu.ru> <4A6DFFA1.1010709@elischer.org> <4A6E0121.2020004@sfedu.ru> <4A6E05EC.8050401@elischer.org> <4A6E0A8B.5000103@sfedu.ru> <4A6E2666.2040906@elischer.org> <4A6E3743.7050708@elischer.org> <1248788292.71222.10.camel@brain.cc.rsu.ru> <4A6F1D76.7040806@elischer.org> <4A6F24BB.7050907@sfedu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Oleg Sharoyko wrote: > Julian Elischer wrote: > >> I'll get that checked in! > > Please, also take a look at > > _syncache_add() in tcp_syncache.c > > There is some code which looks strange, at least at first sight. Won't > bcopy() overwrite assigned value of sc->sc_inc.inc_fibnum ? > > /* XXX-BZ this fib assignment is just useless. */ > sc->sc_inc.inc_fibnum = inp->inp_inc.inc_fibnum; > bcopy(inc, &sc->sc_inc, sizeof(struct in_conninfo)); the bcopy just writes teh same vlue in again I've removed this in the patch. > > -- > Oleg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A6F2533.4050007>