From owner-freebsd-bugs@FreeBSD.ORG Sat Feb 25 23:00:20 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2C4B16A420 for ; Sat, 25 Feb 2006 23:00:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D73543D4C for ; Sat, 25 Feb 2006 23:00:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1PN0KGw022560 for ; Sat, 25 Feb 2006 23:00:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1PN0KDg022559; Sat, 25 Feb 2006 23:00:20 GMT (envelope-from gnats) Date: Sat, 25 Feb 2006 23:00:20 GMT Message-Id: <200602252300.k1PN0KDg022559@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Stephen Montgomery-Smith Cc: Subject: Re: bin/93841: seg fault with dmesg X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stephen Montgomery-Smith List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Feb 2006 23:00:20 -0000 The following reply was made to PR bin/93841; it has been noted by GNATS. From: Stephen Montgomery-Smith To: bug-followup@FreeBSD.org, stephen@math.missouri.edu Cc: Subject: Re: bin/93841: seg fault with dmesg Date: Sat, 25 Feb 2006 16:57:56 -0600 Actually my suggested fix isn't going to work in every situation. How about: --- dmesg.c-orig Sat Feb 25 16:26:18 2006 +++ dmesg.c Sat Feb 25 16:52:11 2006 @@ -184,7 +184,8 @@ errno == 0) { if (LOG_FAC(pri) != LOG_KERN && !all) continue; - p = q + 1; + if (q < nextp) + p = q + 1; } } (This patch is unlikely to apply cleanly because my mail client has probably messed it up.)