From owner-svn-src-all@freebsd.org Tue Feb 12 16:25:42 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94E6114EBC4D for ; Tue, 12 Feb 2019 16:25:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 26FB36CC6A for ; Tue, 12 Feb 2019 16:25:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x834.google.com with SMTP id b8so3588870qtr.9 for ; Tue, 12 Feb 2019 08:25:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pclRw20DVgQh4D4aPcAbrlWT59qDFOC+ukliZGRxPOA=; b=zWpNP7izdsyfIGrBkVjU7xtC4zwrzmJwqaonrHqH31WzUzKYhgXnp77yaArKsOptmn efn7FPtEBBZUN53hGK5b1wfLfVO9cM0fMwSEZ95Ea0+4rx3Eqf8mNK7W2wpz69AVvpUL aqG9CVJqB3KcmeRYaG22kD7lLRrFBtZPJ1yFZkW1ZrXNJ0amborXHnL8CgTXFU6tsOeN mbXGu0ieIioQsAPfHPEa73ANgie1XT7dCLE4vqwoxeTg7VBLL+4KrUFZpljWA8DX3iAe bvabMxnB5twtXaBX0Tnfe8dTR29jdy66HX8Nlq0lLe5qPv4EKC+6vxW/zZfXtwFeKeGA XPKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pclRw20DVgQh4D4aPcAbrlWT59qDFOC+ukliZGRxPOA=; b=NgLqxqxM7AGRyP+v0jELAqnQ4sVyNZtwnh4cIDelHoQlXiyWF9wpeQmzOnjr92VbJY WVpneZqgsjpFRH9CMmZo9yGp6kWj+H5G25QPBig6nqsdiV/VCTIzrKjvpUl9ABLYOBsD nH4ZEQYVQR1dslHq2gyjhRrr1T2PGGt0Hnqa516zUb6e7jbZZjBAdIPNvuHUHPWt1cEe I4n4s+WGxOj7Uss1PVxm2pRgyc7hpfsON4B4OVg83xFrzdA+aQtpiHm37czhaq3Nmz6s 8Bke3RudG2bsEovkJZmFY2xJe6nlTluc6oW6ICJecH7MkiMQELg9taeTQeS9sv5HRLdQ ckUg== X-Gm-Message-State: AHQUAubV7GXyphtFCk9U4nrFFHdejFc0KeLq5pNXEc4jPV8Hsgp1cxEt m19Z4V1gynVGrRFBFMJYZaQRRa9MacLNxMpYKT5MbpK6 X-Google-Smtp-Source: AHgI3IYzVX8iAn1SyDO9n8hyy7chWy1cOOlR4HeTh3eT4Xu3Co0XsD/A9sTsRXwoQNeFL2YHnnI4jXIEHEId98+HfP4= X-Received: by 2002:ac8:16d0:: with SMTP id y16mr3348342qtk.345.1549988741521; Tue, 12 Feb 2019 08:25:41 -0800 (PST) MIME-Version: 1.0 References: <201902121621.x1CGL5dq076678@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201902121621.x1CGL5dq076678@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Tue, 12 Feb 2019 09:25:30 -0700 Message-ID: Subject: Re: svn commit: r344051 - in stable/12/sbin: newfs tunefs To: "Rodney W. Grimes" Cc: Dmitry Morozovsky , Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org X-Rspamd-Queue-Id: 26FB36CC6A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 16:25:42 -0000 On Tue, Feb 12, 2019 at 9:21 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Tue, 12 Feb 2019, Cy Schubert wrote: > > > > > In message <201902121358.x1CDwGf9047873@repo.freebsd.org>, Dmitry > > > Morozovsky wr > > > ites: > > > > Author: marck (doc committer) > > > > Date: Tue Feb 12 13:58:16 2019 > > > > New Revision: 344051 > > > > URL: https://svnweb.freebsd.org/changeset/base/344051 > > > > > > > > Log: > > > > MFC 343548: > > > > > > > > Allow dashes as a valid character in UFS labels. > > > > > > Approved by: Whom? > > > > Sorry, I missed commit log metadata from the original change. > > > > Lesson learnt. > > I think your fine on how you did this, I certainly already > knew from reading the ^head commits that this change had > infact been approved by Kirk, and had been flagged for MFC. > > I do not see value in duplicationg all that info in the > stable branches, but perhaps we should formalize that in > the committers guide on commit messages? > Let's not overreact. Someone made a commit, someone else didn't go check the original commit to see it was legit and asked a question. The original bonafides were provided. Case closed. No need to make a federal case out of it. The doc committer learned to take a little extra care on their commit messages, it seems, as doc committers committing to src get a little extra scrutiny. The original complainer likely noticed the info was in the original commit and may check there in the future before complaining. Or maybe he won't. It isn't a big deal either way. None of this requires a change to the rules. Warner