From owner-svn-src-head@FreeBSD.ORG  Fri Dec 18 23:38:32 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A895A1065679
	for <svn-src-head@freebsd.org>; Fri, 18 Dec 2009 23:38:32 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 3757F8FC19
	for <svn-src-head@freebsd.org>; Fri, 18 Dec 2009 23:38:32 +0000 (UTC)
Received: (qmail 20166 invoked by uid 399); 18 Dec 2009 23:38:31 -0000
Received: from localhost (HELO foreign.dougb.net)
	(dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 18 Dec 2009 23:38:31 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4B2C127A.8060509@FreeBSD.org>
Date: Fri, 18 Dec 2009 15:38:34 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Thunderbird 2.0.0.23 (X11/20091206)
MIME-Version: 1.0
To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no>
References: <200912161717.nBGHHeQZ005541@svn.freebsd.org>	<200912161541.53834.jhb@freebsd.org>
	<868wd0cyjd.fsf@ds4.des.no>
In-Reply-To: <868wd0cyjd.fsf@ds4.des.no>
X-Enigmail-Version: 0.96.0
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Warner Losh <imp@freebsd.org>,
	John Baldwin <jhb@freebsd.org>
Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Dec 2009 23:38:32 -0000

Dag-Erling Smørgrav wrote:
> John Baldwin <jhb@freebsd.org> writes:
>> Warner Losh <imp@freebsd.org> writes:
>>> Log:
>>>   Fix compiling FREEBSD_COMPAT[4,5,6] without FREEBSD_COMPAT7.
>>>   
>>>   Note: Not sure this is the right way to do compat, but it makes the
>>>   headers consistent with the implementations.
>> Please revert.  I think this has already been reverted once before.
> 
> Yep, that was me...  we concluded back then that this is a perfectly
> reasonable dependency; perhaps we should simply add the appropriate
> #ifndef / #error constructs so you can't define FREEBSD_COMPAT(n)
> without FREEBSD_COMPAT(n+1).

Trying to look at this from the user perspective, it's kind of silly
that if what I want is COMPAT5 I also need to add COMPAT<somethingelse>.

I don't know the issues in the code so I don't know what the solution
should be on the back end, but on the front end what needs to work is
that I specify the compat level I want in my kernel config, then the
code does what's necessary to make that work.


Doug

-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/