Date: Wed, 6 Jan 2010 18:40:06 GMT From: "Pedro F. Giffuni" <giffunip@tutopia.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD Message-ID: <201001061840.o06Ie6vm064543@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/142384; it has been noted by GNATS. From: "Pedro F. Giffuni" <giffunip@tutopia.com> To: Antoine Brodin <antoine@FreeBSD.org> Cc: freebsd-gnats-submit@freebsd.org Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD Date: Wed, 6 Jan 2010 10:05:33 -0800 (PST) ----- Original Message ---- ... > > This does not look right, you probably want: > if ((n = read(dosfs, block, sizeof(block))) == -1 || n != sizeof(block)) > Hmm... It was taken as-is from OpenBSD's CVS http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/fsck_msdos/boot.c.diff?r1=1.12;r2=1.13 but I have no objection with adding the parenthesis. cheers, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001061840.o06Ie6vm064543>