From owner-svn-src-head@freebsd.org Wed May 9 12:48:36 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD9BEFB7CD6; Wed, 9 May 2018 12:48:36 +0000 (UTC) (envelope-from thj@freebsd.org) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 69E2F7A4E2; Wed, 9 May 2018 12:48:36 +0000 (UTC) (envelope-from thj@freebsd.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id B54E720F62; Wed, 9 May 2018 08:48:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 09 May 2018 08:48:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=p8f57qLp8cuYulJFBihsq8a5GuY/s aHkuqaIMWTpRyc=; b=KcI8Es/TCzXRymPT60Yumf3VlXZ56dL2PRunb59VombBI dMDrAe19LRuenzKnTh8JvUKSVoEBrDqqJe6b7LIOcbUf6KTck8HKrTGXUDipX1it Vn8/B2KU5kPo8kOeDxiIgVC3IuEOGSYK6ohZOsZ+mdRixdreuiNtnaaf1WKmBY8G p/93IY9VxBMMiDQwEHGQqzz5VZAJv9vdCtb8C7Irq4YAbG/0MsCTac7PU5Aq5kLU 84KCJ2uhfDLEf2wi420qtKbr86XgCbvl+HhtGrCmT/xOAjRN+OOHy3stYqhGrUcE viTTCQhx6Dd1LK0j++mlTjpeb1QgGQ4xTbz8OttSw== X-ME-Sender: Received: from tom-desk.erg.abdn.ac.uk (tom-desk.erg.abdn.ac.uk [139.133.204.4]) by mail.messagingengine.com (Postfix) with ESMTPA id F310610285; Wed, 9 May 2018 08:48:34 -0400 (EDT) Date: Wed, 9 May 2018 13:48:20 +0100 From: Tom Jones To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333309 - in head/sys: net netinet netinet6 Message-ID: <20180509124820.GA34572@tom-desk.erg.abdn.ac.uk> References: <201805062034.w46KYDUY088148@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201805062034.w46KYDUY088148@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:48:37 -0000 On Sun, May 06, 2018 at 08:34:13PM +0000, Matt Macy wrote: > Author: mmacy > Date: Sun May 6 20:34:13 2018 > New Revision: 333309 > URL: https://svnweb.freebsd.org/changeset/base/333309 > > Log: > r333175 introduced deferred deletion of multicast addresses in order to permit the driver ioctl > to sleep on commands to the NIC when updating multicast filters. More generally this permitted > driver's to use an sx as a softc lock. Unfortunately this change introduced a race whereby a > a multicast update would still be queued for deletion when ifconfig deleted the interface > thus calling down in to _purgemaddrs and synchronously deleting _all_ of the multicast addresses > on the interface. > > Synchronously remove all external references to a multicast address before enqueueing for delete. > Hi Matt, I am getting periodic panics on a FreeBSD CURRENT guest running bhyve on a 11.1 Host. An idle guest will panic after about 5 minutes. Reverting this commit stops the panics. Fatal trap 9: general protection fault while in kernel mode cpuid = 0; apic id = 00 instruction pointer = 0x20:0xffffffff80db01ac stack pointer = 0x28:0xfffffe00121827d0 frame pointer = 0x28:0xfffffe0012182800 code segment = base 0x0, limit 0xfffff, type 0x1b = DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags = interrupt enabled, resume, IOPL = 0 current process = 12 (swi4: clock (0)) [ thread pid 12 tid 100023 ] Stopped at in6m_disconnect+0x13c: cmpq %r13,(%rcx) db> bt Tracing pid 12 tid 100023 td 0xfffff8000322d000 in6m_disconnect() at in6m_disconnect+0x13c/frame 0xfffffe0012182800 mld_fasttimo() at mld_fasttimo+0x62b/frame 0xfffffe00121828d0 pffasttimo() at pffasttimo+0x54/frame 0xfffffe0012182900 softclock_call_cc() at softclock_call_cc+0x150/frame 0xfffffe00121829b0 softclock() at softclock+0x7c/frame 0xfffffe00121829e0 intr_event_execute_handlers() at intr_event_execute_handlers+0x99/frame 0xfffffe0012182a20 ithread_loop() at ithread_loop+0xb7/frame 0xfffffe0012182a70 fork_exit() at fork_exit+0x84/frame 0xfffffe0012182ab0 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0012182ab0 --- trap 0, rip = 0, rsp = 0, rbp = 0 --- - [tj]