From owner-cvs-all Tue Sep 10 15:52:11 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31D3937B400; Tue, 10 Sep 2002 15:52:04 -0700 (PDT) Received: from creme-brulee.marcuscom.com (rdu57-17-158.nc.rr.com [66.57.17.158]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48A4E43E6A; Tue, 10 Sep 2002 15:52:03 -0700 (PDT) (envelope-from marcus@FreeBSD.org) Received: from [10.2.1.0] (vpn-client-0.marcuscom.com [10.2.1.0]) by creme-brulee.marcuscom.com (8.12.5/8.12.5) with ESMTP id g8AMndiv092056; Tue, 10 Sep 2002 18:49:39 -0400 (EDT) (envelope-from marcus@FreeBSD.org) Subject: Re: cvs commit: ports/x11-fm/nautilus Makefile ports/x11-fm/nautilus/files patch-libnautilus-private::nautilus-volume-monitor.c From: Joe Marcus Clarke To: Maxim Sobolev Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20020910220212.GC3821@vega.vega.com> References: <200209102024.g8AKO7kA047896@freefall.freebsd.org> <20020910220212.GC3821@vega.vega.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 Date: 10 Sep 2002 18:51:42 -0400 Message-Id: <1031698302.43819.30.camel@gyros.marcuscom.com> Mime-Version: 1.0 X-Spam-Status: No, hits=-2.5 required=5.0 tests=IN_REP_TO,AWL version=2.31 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 2002-09-10 at 18:02, Maxim Sobolev wrote: > On Tue, Sep 10, 2002 at 01:24:07PM -0700, Joe Marcus Clarke wrote: > > marcus 2002/09/10 13:24:07 PDT > > > > Modified files: > > x11-fm/nautilus Makefile > > x11-fm/nautilus/files > > patch-libnautilus-private::nautilus-volume-monitor.c > > Log: > > Port sobomax's nautilus2 volume patches to nautilus, and take things a step > > further. Now, removable media such as CDs, Zip drives, etc. are correctly > > handled by nautilus with pretty little icons. Bump PORTREVISION. > > WOW, wonderfull! Any plans to backport (forwardport maybe) those changes > for nautilus2? > Working on it now. I had to write some code to get the CD names to pop up correctly. Funny you should write, I have a question. You changed the code for detecting removable media to look for /mnt/ in the mount point name. I don't think this is right for FreeBSD. hier(7) says /mnt is used as a temporary mount point, and FreeBSD uses /cdrom. I've, therefore, changed the code to always return TRUE when asked if the volume is removable. This seems okay since the function only passes removable volumes into it anyway. The other solution is to go back to looking for "noauto" in fs_mntops. What do you think? Joe > -Maxim > -- Joe Marcus Clarke FreeBSD GNOME Team :: marcus@FreeBSD.org http://www.FreeBSD.org/gnome To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message