Date: Fri, 07 Jan 2022 19:32:39 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261012] net-p2p/deluge-cli: optional dependency py38-setproctitle makes service script status break [PATCH] Message-ID: <bug-261012-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261012 Bug ID: 261012 Summary: net-p2p/deluge-cli: optional dependency py38-setproctitle makes service script status break [PATCH] Product: Ports & Packages Version: Latest Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: rm@FreeBSD.org Reporter: jocke@gipset.se Flags: maintainer-feedback?(rm@FreeBSD.org) Assignee: rm@FreeBSD.org Created attachment 230794 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D230794&action= =3Dedit removes dep on setproctitle and use pidfile in deluge-web service script This is my first bug report in freebsd, please be gentle :) I noticed deluge-web could not be restarted through its service script so I went looking into why. It turns out it doesn't set a pidfile. Fixing that, I immediately had another problem, that the process in the pid file could not= be matched by rc.subr[0] so it could not be restarted even with pidfile. It seems what while setproctitle makes for nice ps/top/htop output, it conf= uses rc.subr such that e.g. `service deluge-web status` cannot find the process = and stop/restart will not work (since the old process is still alive the new one cannot bind to the same port and fails with warnings in logs). Motivation for adding it to deluge in the first place [1]: > Set process name to match application using setproctitle > Using the setproctitle module the process name displayed in top > and other places will correctly reflect the binary name. This is an > optional dependency I believe, since the dependency is optional and falls back to noop implementations, that having functioning service scripts is more important = than nicer output in `ps`. A patch is included that is taken from my running sys= tem, but I have not actually tried these changes all the way from a manual port build (I am very new to freebsd so not exactly sure how to verify things anyway). [0]: https://cgit.freebsd.org/src/tree/libexec/rc/rc.subr#n316 [1]: https://github.com/deluge-torrent/deluge/commit/b396b11611be9c828090d1dafed= fb3cd3bf092f3 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-261012-7788>