From owner-freebsd-gnome@FreeBSD.ORG Thu Feb 22 11:20:11 2007 Return-Path: X-Original-To: gnome@freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3FE8516A401 for ; Thu, 22 Feb 2007 11:20:11 +0000 (UTC) (envelope-from mark.evenson@gmx.at) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id 8798A13C428 for ; Thu, 22 Feb 2007 11:20:10 +0000 (UTC) (envelope-from mark.evenson@gmx.at) Received: (qmail invoked by alias); 22 Feb 2007 11:20:08 -0000 X-Provags-ID: V01U2FsdGVkX1/Balk6Z33Bcj+R6Gjx26sBpTwEOiPKoRTgGRb7hG d+Ow== Message-ID: <45DD7C66.6000103@gmx.at> Date: Thu, 22 Feb 2007 12:20:06 +0100 From: Mark Evenson User-Agent: Thunderbird 1.5.0.9 (X11/20070119) MIME-Version: 1.0 To: Jeremy Messenger References: <200702202206.l1KM6pR8090517@freefall.freebsd.org> <45DC593F.1070407@gmx.at> In-Reply-To: Content-Type: multipart/mixed; boundary="------------040402020603080206080701" X-Y-GMX-Trusted: 0 Cc: gnome@freebsd.org Subject: Re: ports/108967: sysutils/gnome-control-center 2.16.3 gnome-keyboard-properties dumps core on startup X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 11:20:11 -0000 This is a multi-part message in MIME format. --------------040402020603080206080701 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Attached is a coredump with libklavier symbols and my ports are current wrt. cvsup. It seems that this problem has been resolved upstream as the GNOME bug-buddy filed this report with gnome.org as http://bugzilla.gnome.org/show_bug.cgi?id=410382 So I have attached a patch for x11/libxklavier until the upstream changes make it into FreeBSD. Can you forward this to the x11/libxklavier maintainer? --------------040402020603080206080701 Content-Type: text/plain; name="gnome-keyboard-properties-bt" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="gnome-keyboard-properties-bt" (gdb) thread apply all bt full [New Thread 0x8069200 (LWP 100250)] Thread 3 (Thread 0x8069200 (LWP 100250)): #0 0x290414f7 in pthread_testcancel () from /lib/libpthread.so.2 No symbol table info available. #1 0x29039ec8 in pthread_mutexattr_init () from /lib/libpthread.so.2 No symbol table info available. #2 0x29cb3450 in ?? () No symbol table info available. Thread 2 (Thread 0x8069000 (LWP 100259)): #0 xkl_read_config_item (iptr=3D0x0, item=3D0x805f680) at xklavier_confi= g.c:52 name_element =3D 0x8215000 nptr =3D 0x82102c0 ptr =3D 0x82102c0 desc_element =3D 0x0 short_desc_element =3D 0x0 nt_desc_element =3D 0x0 nt_short_desc_element =3D 0x0 max_desc_priority =3D -1 max_short_desc_priority =3D -1 #1 0x28be6e96 in xkl_config_registry_find_object (config=3D0x8215000, fo= rmat=3D0x28bee9a8 "/xkbConfigRegistry/layoutList/layout[configItem/name =3D= '%s%s']", arg1=3D0x28bedaec "", pitem=3D0x805f680, pnode=3D0x0) at xklav= ier_config.c:247 xpath_obj =3D 0x8215000 nodes =3D 0x82102c0 rv =3D 0 xpath_expr =3D "/xkbConfigRegistry/layoutList/layout[configItem/name =3D= 'en']\000\201\003)\000\220\006\bH\220\006\b", '\0' , "= =B4D\004\001\230%\b(:w\003)", '\0' , "X\207=C2(\001\000= \000\000\000n\037\b8=E6=BF=BFw=F9=C0(=D4\211=C2(\001\000\000\000\000\035\= 030(\t=F0=C0(=B9\004\004\n=BDB=A1(\200Q=CB(\b=E6=BF=BF\200Q=CB(\200Q=CB(\= b=E6=BF=BF\200Q=CB(\000=E6=BF=BF=E0=E5=BF=BF\017\000\000\000 W=CB(@\002!\= b\026\000\000\000\210=E5=BF=BF"... #2 0x28be748e in xkl_config_registry_find_layout (config=3D0x8203660, pi= tem=3D0x805f680) at xklavier_config.c:483 No locals. #3 0x080562fb in gswitchit_kbd_config_get_lv_descriptions (config_regist= ry=3D0x8203660, layout_name=3D0x8210220 "en", variant_name=3D0x0, layout_= short_descr=3D0xbfbfe980, layout_descr=3D0xbfbfe984, variant_short_descr=3D= 0xbfbfe988, variant_descr=3D0xbfbfe98c) at gswitchit-config.c:116 litem =3D {parent =3D {g_type_instance =3D {g_class =3D 0x0}, ref_count = =3D 0, qdata =3D 0x0}, name =3D "\000n", '\0' , short_d= escription =3D '\0' , description =3D '\0' } vitem =3D {parent =3D {g_type_instance =3D {g_class =3D 0x0}, ref_count = =3D 0, qdata =3D 0x0}, name =3D '\0' , short_descriptio= n =3D '\0' , description =3D '\0' }= #4 0x08057929 in gswitchit_kbd_config_get_descriptions (config_registry=3D= 0x8203660, name=3D0x8210210 "en", layout_short_descr=3D0xbfbfe980, layout= _descr=3D0xbfbfe984, variant_short_descr=3D0xbfbfe988, variant_descr=3D0x= bfbfe98c) at gswitchit-config.c:1003 layout_name =3D 0x805fa40 "en" variant_name =3D 0x0 #5 0x08050d74 in xkb_layouts_fill_selected_tree (dialog=3D0x8083660) at = gnome-keyboard-properties-xkblt.c:347 iter =3D {stamp =3D -19819737, user_data =3D 0x8498ce0, user_data2 =3D 0= x14, user_data3 =3D 0x40} l =3D 0x805ba70 "toggled" sl =3D 0x80a03f0 "" v =3D 0x8083660 "\200M\f\b\001" sv =3D 0x80505b8 "U\211=E5VS\203=EC\f=FFu\f=E8=F4=DD=FF=FF\211=C3=BE=FF=FF= =FF=FF\203=C4\004=FFu\b=E8\222=E4=FF=FF\203=C4\020\205=C0u\017\203=EC\fS=E8= \"=DA=FF=FF\2130\203=C4\020\220\203=EC\fV=E8\177=FF=FF=FF\211\034$=E8=AB=D8= =FF=FF\215e=F8[^=C9=C3U\211=E5WVS\203=EC8=FFu\020=E8C=EB=FF=FF\211=C6\203= =C4\020\2038\002\017\205=C9" visible =3D 0x8210210 "en" gce =3D (GConfEntry *) 0x0 layouts =3D (GSList *) 0x8077e38 cur_layout =3D (GSList *) 0x8077e38 list_store =3D (GtkListStore *) 0x80a6c58 #6 0x0804feaf in setup_xkb_tabs (dialog=3D0x8083660, changeset=3D0x0) at= gnome-keyboard-properties-xkb.c:183 peditor =3D (GObject *) 0x0 #7 0x0804f83a in setup_dialog (dialog=3D0x8083660, changeset=3D0x0) at g= nome-keyboard-properties.c:172 peditor =3D (GObject *) 0x8203300 #8 0x0804fa8e in main (argc=3D1, argv=3D0xbfbfea8c) at gnome-keyboard-pr= operties.c:252 client =3D (GConfClient *) 0x8083660 dialog =3D (GladeXML *) 0x8083660 apply_only =3D 0 get_legacy =3D 0 switch_to_typing_break_page =3D 0 cap_options =3D {{longName =3D 0x805b3d1 "apply", shortName =3D 0 '\0', = argInfo =3D 0, arg =3D 0x805f620, val =3D 0, descrip =3D 0x805b838 "Just = apply settings and quit (compatibility only; now handled by daemon)", arg= Descrip =3D 0x0}, {longName =3D 0x805b3d7 "init-session-settings", shortN= ame =3D 0 '\0', argInfo =3D 0, arg =3D 0x805f620, val =3D 0, descrip =3D = 0x805b838 "Just apply settings and quit (compatibility only; now handled = by daemon)", argDescrip =3D 0x0}, {longName =3D 0x805b3ed "get-legacy", s= hortName =3D 0 '\0', argInfo =3D 0, arg =3D 0x805f624, val =3D 0, descrip= =3D 0x805b884 "Retrieve and store legacy settings", argDescrip =3D 0x0},= {longName =3D 0x805b3f8 "typing-break", shortName =3D 0 '\0', argInfo =3D= 0, arg =3D 0x805f628, val =3D 0, descrip =3D 0x805b8a8 "Start the page w= ith the typing break settings showing", argDescrip =3D 0x0}, {longName =3D= 0x0, shortName =3D 0 '\0', argInfo =3D 0, arg =3D 0x0, val =3D 0, descri= p =3D 0x0, argDescrip =3D 0x0}} (gdb) --------------040402020603080206080701 Content-Type: text/plain; name="patch-libxklavier_xklavier_config.c" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch-libxklavier_xklavier_config.c" --- libxklavier/xklavier_config.c.orig Sun Apr 16 04:04:38 2006 +++ libxklavier/xklavier_config.c Thu Feb 22 12:14:41 2007 @@ -243,7 +243,7 @@ return FALSE; nodes = xpath_obj->nodesetval; - if (nodes != NULL && nodes->nodeTab != NULL) { + if (nodes != NULL && nodes->nodeTab != NULL && *nodes->nodeTab != NULL) { rv = xkl_read_config_item(*nodes->nodeTab, pitem); if (pnode != NULL) { *pnode = *nodes->nodeTab; @@ -275,7 +275,11 @@ gchar * xkl_strings_concat_comma_separated(gchar ** array) { - return g_strjoinv(",", array); + if (array) { + return g_strjoinv(",", array); + } else { + return g_strdup(""); + } } void --------------040402020603080206080701--