From owner-svn-src-head@FreeBSD.ORG Fri Nov 9 18:06:52 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8796A201; Fri, 9 Nov 2012 18:06:52 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 543438FC0C; Fri, 9 Nov 2012 18:06:51 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id e12so4026876lag.13 for ; Fri, 09 Nov 2012 10:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=ZopoGox3pNUfCSf275b+e/TXW3jMDr1ZBjcDSWfHoHI=; b=wQz7Lv2uC7S9MJkJawRoo+yhDvh+3UxaPPOe0UtnfgWFOu29wgYKjuHZ3aniC4tiXa v4rhsEWLisSGK4KjucloXsoODLLXVjq1r9rTezpLBpB2ulHwlz8txIM5ZIO/cMaQIeaq PW+ZIwG/VU8LQ5V/Setf6MZOdqqBYTygFbxQjmLefLuu06EuuMzEPL4psKSoPQLJ2SKf 0JYlISHjPL0SmbJ69jbhm94KFCpqulwOd4X4055GfS5PocxVleYOVxciGV+7zSsaQJQ+ 2iKu1gqt5GiiSl+IFypngJ2ZXye6gFPQ5zHSNWwiIi645y36mTCd2ihqvQ3TlA245u2d 4sUw== MIME-Version: 1.0 Received: by 10.152.105.103 with SMTP id gl7mr11195199lab.10.1352484410006; Fri, 09 Nov 2012 10:06:50 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.112.30.37 with HTTP; Fri, 9 Nov 2012 10:06:49 -0800 (PST) In-Reply-To: References: <201210221750.q9MHot26061585@svn.freebsd.org> Date: Fri, 9 Nov 2012 18:06:49 +0000 X-Google-Sender-Auth: fHZTqy9pmggbuY6ijrBzHsJpDBY Message-ID: Subject: Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/openso... From: Attilio Rao To: Ben Kaduk Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2012 18:06:52 -0000 On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk wrote: > On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov wrote: >> Author: kib >> Date: Mon Oct 22 17:50:54 2012 >> New Revision: 241896 >> URL: http://svn.freebsd.org/changeset/base/241896 >> >> Log: >> Remove the support for using non-mpsafe filesystem modules. >> >> In particular, do not lock Giant conditionally when calling into the >> filesystem module, remove the VFS_LOCK_GIANT() and related >> macros. Stop handling buffers belonging to non-mpsafe filesystems. >> >> The VFS_VERSION is bumped to indicate the interface change which does >> not result in the interface signatures changes. >> >> Conducted and reviewed by: attilio >> Tested by: pho >> > > Sorry for late reply. > > % --- head/sys/sys/namei.h 2011/12/29 12:28:05 228952 > % +++ head/sys/sys/namei.h 2012/10/22 17:50:54 241896 > % @@ -144,15 +144,11 @@ > % #define ISOPEN 0x00200000 /* caller is opening; return a real vnode. */ > % #define NOCROSSMOUNT 0x00400000 /* do not cross mount points */ > % #define NOMACCHECK 0x00800000 /* do not perform MAC checks */ > % -#define MPSAFE 0x01000000 /* namei() must acquire Giant if needed. */ > > It seems that removing the definition of MPSAFE causes out-of-tree > filesystem modules to not build. > Perhaps a definition can remain for some period to allow a smoother transition? > Conditional on __FreeBSD_Version is the proper fix, of course, but > takes longer to get everywhere. Hi Ben, FYI I've now removed also MNTK_MPSAFE flag. I know this could introduce some more "turbolence" for porting thirdy part stuff, but actually this only gives one single breakage window and now people can fix correctly their port/thirdy part just once. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein