From owner-freebsd-current@FreeBSD.ORG  Sat Apr  7 01:59:33 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9A4D21065672
	for <freebsd-current@freebsd.org>; Sat,  7 Apr 2012 01:59:33 +0000 (UTC)
	(envelope-from kwhite@site.uottawa.ca)
Received: from courriel.site.uottawa.ca (eecsmail.engineering.uottawa.ca
	[137.122.24.224])
	by mx1.freebsd.org (Postfix) with ESMTP id 598398FC08
	for <freebsd-current@freebsd.org>; Sat,  7 Apr 2012 01:59:33 +0000 (UTC)
Received: from courriel.site.uottawa.ca (localhost [127.0.0.1])
	by courriel.site.uottawa.ca (8.14.4/8.14.4) with ESMTP id
	q371aTIb059809
	for <freebsd-current@freebsd.org>; Fri, 6 Apr 2012 21:36:29 -0400 (EDT)
	(envelope-from kwhite@site.uottawa.ca)
Received: from 74.51.53.177 (SquirrelMail authenticated user kwhite)
	by courriel.site.uottawa.ca with HTTP;
	Fri, 6 Apr 2012 21:36:29 -0400 (EDT)
Message-ID: <55056.74.51.53.177.1333762589.squirrel@courriel.site.uottawa.ca>
Date: Fri, 6 Apr 2012 21:36:29 -0400 (EDT)
From: kwhite@site.uottawa.ca
To: freebsd-current@freebsd.org
User-Agent: SquirrelMail/1.4.5
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-15
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
X-Mailman-Approved-At: Sat, 07 Apr 2012 03:43:54 +0000
Subject: (unionfs) panic: excl->share with r230341 and above
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Apr 2012 01:59:33 -0000

Starting with r230341, I get the following panic when trying to run
an executable on a unionfs filesystem:

        exclusive lock of (lockmgr) ufs @
/usr/src/sys/modules/unionfs/../../fs/unionfs/union_vnops.c:1843
        while share locked from
/usr/src/sys/modules/unionfs/../../fs/unionfs/union_vnops.c:1843
        panic: excl->share
        cpuid = 0
        KDB: enter: panic

Narrowing down with a binary search: r230340 (no panic), r230341 (panic).

How to repeat:
        # uuname -a
        FreeBSD  10.0-CURRENT FreeBSD 10.0-CURRENT #5 r233946M: Fri Apr  6
21:09:32 EDT 2012     kwhite@demo:/usr/src/obj/usr/src/sys/GENERIC
 i386

        # mkdir /tmp/local
        # mount -t unionfs -o noatime /tmp/local /usr/local
        # cp /bin/ls /usr/local/bin/ls
        # /usr/local/bin/ls
        ....
        exclusive lock of (lockmgr) ufs @
/usr/src/sys/modules/unionfs/../../fs/unionfs/union_vnops.c:1843
        while share locked from
/usr/src/sys/modules/unionfs/../../fs/unionfs/union_vnops.c:1843
        panic: excl->share
        cpuid = 0
        KDB: enter: panic
        [ thread pid 68 tid 100054 ]
        Stopped at      kdb_enter+0x3b: movl    $0,kdb_why
        db> show all locks
        Process 68 (ls) thread 0xc5780000 (100054)
        exclusive sleep mutex vnode interlock (vnode interlock) r = 0
(0xc57cec28) locked @
/usr/src/sys/modules/unionfs/../../fs/unionfs/union_vnops.c:1835
        shared lockmgr ufs (ufs) r = 0 (0xc57cec08) locked @
/usr/src/sys/modules/unionfs/../../fs/unionfs/union_vnops.c:1843
        db>

Workaround?
        After reverting the change from LK_EXCLUSIVE to LK_SHARED
        in sys/kern/kern_exec.c, executables on union filesystems no
        longer cause a panic.

...keith