From owner-svn-src-head@freebsd.org Fri Jan 25 13:55:18 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2AE5B14B69F9; Fri, 25 Jan 2019 13:55:18 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9292984A03; Fri, 25 Jan 2019 13:55:17 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lj1-f176.google.com with SMTP id v1-v6so8474053ljd.0; Fri, 25 Jan 2019 05:55:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BWAOJUdGRzA68AYFUaWyeHGnKWknI5G/2Af/Z5IE6v0=; b=KJ/U4RuBHNomT7FV4sf4heAfaPqvkSboLsZqSzILeSXOc9LSbYovNbACK0ATixoYry EXQ6Z1yu5l6lffPexUt8K3Vrx+bwHAa1D7YLZUHUN4L4R/ni48WyCUImPjwYeid5jqpR 8yxrMS6PcXp58gxwoxtB8Ds1q4QGSmofezacjUv9Yj41EkpJ982UWpxWCwo2B5zzbFRr AZRhytz0cEv53daGr/y70LLF5UPwdclEyIUupK9NOfqQBuCBjk0cYYa7rqwy7wRpcUJQ kpXWvbv+pyg9wiqYMYMofQS5oWjnHQ+VWLnspoGA1lDQYIOJhDyRcPlCBRsANEhU05IO uMCw== X-Gm-Message-State: AJcUukeLgZelVhKN/MdEzK3jF+VHbWkAo8yCR7Sa3ZRLqLiuumTOQqc1 Pu30eob4Qp06CrUmhy4VmcwuvQnq X-Google-Smtp-Source: ALg8bN4OrGU/Ju5xobMfkUuosSJLHGGz1OAOiS3VS/QGTyu1rYatcjhDWDwdBgvIuBdSQPO75dYDrA== X-Received: by 2002:a2e:20f:: with SMTP id 15-v6mr9290759ljc.172.1548424105885; Fri, 25 Jan 2019 05:48:25 -0800 (PST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id o5-v6sm1475533ljh.75.2019.01.25.05.48.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 05:48:25 -0800 (PST) Received: by mail-lj1-f178.google.com with SMTP id q2-v6so8413851lji.10; Fri, 25 Jan 2019 05:48:24 -0800 (PST) X-Received: by 2002:a2e:710a:: with SMTP id m10-v6mr8836459ljc.66.1548424104712; Fri, 25 Jan 2019 05:48:24 -0800 (PST) MIME-Version: 1.0 References: <201901251344.x0PDiGZP088635@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201901251344.x0PDiGZP088635@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Fri, 25 Jan 2019 07:47:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r343349 - head/sys/dev/ocs_fc To: "Rodney W. Grimes" Cc: Ram Kishore Vegesna , Ram Kishore Vegesna , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9292984A03 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 13:55:18 -0000 On Fri, Jan 25, 2019 at 7:44 AM Rodney W. Grimes wrote: > > > Hi Rodney, > > > > I fixed many coverity tool warnings as part of this commit. Adding all the > > warnings and fix details seemed over kill. > > It seems like overkill when your commiting, but if you have > have to go digging through commit history trying to find > something it helps a great deal to have good information > present there. > > You do not need to include the output from coverty, > but some amount of detail is very helpful. > We do have a tendency to note CIDs in commit messages and that's pretty helpful -- I don't know that omitting them will generally ruffle any feathers, though.