From owner-svn-src-all@FreeBSD.ORG Sun Dec 11 21:02:33 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF278106566B; Sun, 11 Dec 2011 21:02:33 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id CF4408FC0C; Sun, 11 Dec 2011 21:02:33 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id pBBL2XnZ069034; Sun, 11 Dec 2011 21:02:33 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id pBBL2XQs069032; Sun, 11 Dec 2011 21:02:33 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <201112112102.pBBL2XQs069032@svn.freebsd.org> From: Ed Schouten Date: Sun, 11 Dec 2011 21:02:33 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r228425 - head/usr.sbin/vidcontrol X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Dec 2011 21:02:34 -0000 Author: ed Date: Sun Dec 11 21:02:33 2011 New Revision: 228425 URL: http://svn.freebsd.org/changeset/base/228425 Log: Add static keywords to vidcontrol(1). While there, remove the false optimisation of the colors array. It seems that changing it to an array of pointers instead of a 16x16 array does not cause any increase in binary size at all. Modified: head/usr.sbin/vidcontrol/vidcontrol.c Modified: head/usr.sbin/vidcontrol/vidcontrol.c ============================================================================== --- head/usr.sbin/vidcontrol/vidcontrol.c Sun Dec 11 21:02:01 2011 (r228424) +++ head/usr.sbin/vidcontrol/vidcontrol.c Sun Dec 11 21:02:33 2011 (r228425) @@ -63,7 +63,7 @@ static const char rcsid[] = /* Screen dump file format revision */ #define DUMP_FMT_REV 1 -char legal_colors[16][16] = { +static const char *legal_colors[16] = { "black", "blue", "green", "cyan", "red", "magenta", "brown", "white", "grey", "lightblue", "lightgreen", "lightcyan", @@ -78,18 +78,16 @@ struct { struct video_info video_mode_info; } cur_info; -int hex = 0; -int number; -int vesa_cols; -int vesa_rows; -int font_height; -int colors_changed; -int video_mode_changed; -int normal_fore_color, normal_back_color; -int revers_fore_color, revers_back_color; -char letter; -struct vid_info info; -struct video_info new_mode_info; +static int hex = 0; +static int vesa_cols; +static int vesa_rows; +static int font_height; +static int colors_changed; +static int video_mode_changed; +static int normal_fore_color, normal_back_color; +static int revers_fore_color, revers_back_color; +static struct vid_info info; +static struct video_info new_mode_info; /*