From owner-freebsd-bugs@FreeBSD.ORG Tue May 15 04:50:02 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB8061065672 for ; Tue, 15 May 2012 04:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7D2C98FC15 for ; Tue, 15 May 2012 04:50:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4F4o2jU054722 for ; Tue, 15 May 2012 04:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4F4o2IZ054721; Tue, 15 May 2012 04:50:02 GMT (envelope-from gnats) Resent-Date: Tue, 15 May 2012 04:50:02 GMT Resent-Message-Id: <201205150450.q4F4o2IZ054721@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Adrian Chadd Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A2B7F106566C for ; Tue, 15 May 2012 04:43:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 74D7A8FC08 for ; Tue, 15 May 2012 04:43:47 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4F4hl2q039509 for ; Tue, 15 May 2012 04:43:47 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q4F4hlEU039488; Tue, 15 May 2012 04:43:47 GMT (envelope-from nobody) Message-Id: <201205150443.q4F4hlEU039488@red.freebsd.org> Date: Tue, 15 May 2012 04:43:47 GMT From: Adrian Chadd To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/167902: [ath] TX block-ack window holes X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2012 04:50:02 -0000 >Number: 167902 >Category: kern >Synopsis: [ath] TX block-ack window holes >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 15 04:50:02 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Adrian Chadd >Release: 9.0-STABLE i386, with -HEAD net80211/ath >Organization: >Environment: FreeBSD marilyn 9.0-STABLE FreeBSD 9.0-STABLE #0 r235422M: Sun May 13 20:57:56 PDT 2012 adrian@marilyn:/home/adrian/work/freebsd/stable/9/sys/i386/compile/MARILYN-9-STABLE i386 >Description: When doing traffic tests w/ 11n debugging on, I've noticed that the RX side is reporting holes in the TX BA space. Some example logging is: wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <310:373> (0 frames) rxseq 309 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <542:605> (0 frames) rxseq 541 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <831:894> (0 frames) rxseq 830 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <886:949> (0 frames) rxseq 885 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <909:972> (0 frames) rxseq 908 tid 0 (retransmit) --- these wlan1: [00:03:7f:0b:62:88] move BA win <1372:1435> (62 frames) rxseq 1436 tid 0 wlan1: [00:03:7f:0b:62:88] move BA win <1373:1436> (63 frames) rxseq 1437 tid 0 --- these wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <1447:1510> (0 frames) rxseq 1446 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <1561:1624> (0 frames) rxseq 1560 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <1660:1723> (0 frames) rxseq 1659 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <2054:2117> (0 frames) rxseq 2053 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <2107:2170> (0 frames) rxseq 2106 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <2122:2185> (0 frames) rxseq 2121 tid 0 (retransmit) wlan1: [00:03:7f:0b:62:88] discard MPDU frame, BA win <2890:2953> (0 frames) rxseq 2889 tid 0 (retransmit) A pcap of the live traffic showed that some frames inside the BA weren't ever ACKed. I figured that the send side was thus not being properly notified that the transmission failed. I then added some code to ath_tx_processq() to print out ts_status if it's 0 but not HAL_TXERR_XRETRY. It turns out that I was seeing HAL_TXERR_FILT errors. The filtered frames were just being treated as incorrect completions, hence the above BA window slide. >How-To-Repeat: * enable 11n * on the receiving side - wlandebug -i wlanX +11n * .. do some traffic. >Fix: The TX completion routines need to handle non-XRETRY errors. >Release-Note: >Audit-Trail: >Unformatted: